Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major regression in Firefox 35 #2431

Closed
mramato opened this issue Jan 28, 2015 · 4 comments · Fixed by #2432
Closed

Major regression in Firefox 35 #2431

mramato opened this issue Jan 28, 2015 · 4 comments · Fixed by #2432

Comments

@mramato
Copy link
Contributor

mramato commented Jan 28, 2015

There appears to be a major ANGLE related regression in Firefox 35 (obviously Windows only). This causes all existing versions of Cesium to render a lot of materials incorrectly.

image

This was on the DX 9 back end, not sure about DX 11. Disabling Angle fixes the problem. I'll look into filing a Firefox bug, but someone should confirm that this isn't some weird bug on our end that Firefox is exposing.
@mramato
Copy link
Contributor Author

mramato commented Jan 28, 2015

Looks like this is a manifestation of this issue which I found via this issue.

Setting WebGL context alpha to false affects all framebuffers, which causes anything with alpha to go haywire in Cesium. If I force alpha to true in Context.js, everything works (though I'm not sure of the full ramifications of this change).

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 28, 2015

Chime in on those issues and let them know it affects Cesium.

We could workaround this by setting alpha to true, but it is a potential performance hit as it can make the browser compositor work harder.

Is this in any version of Chrome? If not, we could just set alpha : true for Firefox as a workaround for a few months.

@mramato
Copy link
Contributor Author

mramato commented Jan 28, 2015

That's what I would do, check for Firefox 35 and force it to true. We have a similar workaround already in place for Firefox 34, because that broke Cesium as well.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 28, 2015

OK with me.

mramato added a commit that referenced this issue Jan 28, 2015
@mramato
Workaround issue in Firefox 35
3358359 
In Firefox 35 we need to force the context alpha to true because setting
it to false affects all framebuffers. Fixes #2431

Also removed ancient workaround for a Chrome issue that was fixed in
Feb 2014 as well as an unused glsl #ifdef that was left over from an
older version of Firefox.
@mramato mramato mentioned this issue Jan 28, 2015
Merged
mramato added a commit that referenced this issue Jan 29, 2015
@mramato @kring
Workaround issue in Firefox 35
cfc32a7 
In Firefox 35 we need to force the context alpha to true because setting
it to false affects all framebuffers. Fixes #2431

Also removed ancient workaround for a Chrome issue that was fixed in
Feb 2014 as well as an unused glsl #ifdef that was left over from an
older version of Firefox.
@gberaudo gberaudo mentioned this issue Nov 28, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Workaround issue in Firefox 35 CesiumGS/cesium
2 participants
@pjcozzi @mramato