Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated createGooglePhotorealistic3DTileset key option in 1.126 #12328

Open
ggetz opened this issue Nov 22, 2024 · 1 comment · May be fixed by #12330
Open

Remove deprecated createGooglePhotorealistic3DTileset key option in 1.126 #12328

ggetz opened this issue Nov 22, 2024 · 1 comment · May be fixed by #12330
Labels
category - architecture / api good first issue An opportunity for first time contributors remove in 1.126

Comments

@ggetz
Copy link
Contributor

ggetz commented Nov 22, 2024

In #12299, createGooglePhotorealistic3DTileset(key) was deprecated in favor of an options object: createGooglePhotorealistic3DTileset({key}). It should be removed for the 1.126 release.
@ggetz ggetz added good first issue An opportunity for first time contributors category - architecture / api remove in 1.126 labels Nov 22, 2024
@monish-j
Copy link

Hi @ggetz,

I would like to contribute to resolving the issue #12328 regarding the removal of the deprecated createGooglePhotorealistic3DTileset(key) function. Could you please assign this issue to me?

Thank you!

monish-j added a commit to monish-j/cesium that referenced this issue Nov 23, 2024
@monish-j
Remove deprecated createGooglePhotorealistic3DTileset key option in 1…
6614b29 
….126 CesiumGS#12328
@monish-j monish-j linked a pull request Nov 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category - architecture / api good first issue An opportunity for first time contributors remove in 1.126
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated createGooglePhotorealistic3DTileset key option in 1.126 #12328 monish-j/cesium
2 participants
@ggetz @monish-j