Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated createGooglePhotorealistic3DTileset key option in 1.126 #12328 #12330

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

monish-j
Copy link

Summary

This pull request addresses issue #12328 by removing the deprecated createGooglePhotorealistic3DTileset(key) function. The function has been replaced with the new format createGooglePhotorealistic3DTileset({key}).

Changes

  • Removed the deprecated createGooglePhotorealistic3DTileset(key) function.
  • Updated the createGooglePhotorealistic3DTileset function to use the new options object format.
  • Updated CHANGES.md to reflect the removal of the deprecated function.

Verification

  • Verified that the deprecated function is no longer present in the codebase.
  • Ensured that the new format is being used correctly in the createGooglePhotorealistic3DTileset function.
  • Ran tests to confirm that the changes do not introduce any new issues.

Additional Notes

Please let me know if there are any additional documentation updates or other changes needed.

Thank you!

Issue number and link

Fixes #12328

Author checklist

[x] I have submitted a Contributor License Agreement

[x] I have added my name to CONTRIBUTORS.md

[x] I have updated CHANGES.md with a short summary of my change

[x] I have added or updated unit tests to ensure consistent code coverage

[x] I have updated the inline documentation, and included code examples where relevant

[x] I have performed a self-review of my code

Copy link

Thank you for the pull request, @monish-j! Welcome to the Cesium community!

In order for us to review your PR, please complete the following steps:

Review Pull Request Guidelines to make sure your PR gets accepted quickly.

@monish-j
Copy link
Author

Hi @ggetz,

I have removed the deprecated createGooglePhotorealistic3DTileset(key) function and updated the code to use the new format createGooglePhotorealistic3DTileset({key}). The changes have been committed and pushed to the branch remove-deprecated-createGooglePhotorealistic3DTileset-key.

Could you please review the changes and let me know if there are any additional updates or documentation changes needed?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated createGooglePhotorealistic3DTileset key option in 1.126
1 participant