Add exception support to Reinterop #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And handle the possibility that the NativeImplementation property is called on an invalid object (it will now return nullptr).
|
This still has a problem where constructors have an exception parameter in C# but not C++, so don't merge it yet. |
|
Ok this should be ready to go now! |
|
The PR looks good, but seems like there's still a build error on Windows. |
|
The build error is that openssl is failing to build on ARM64 Android. I have no idea what we could've changed to make that happen. Re-running the build to see if it's just a fluke. |
|
Yeah that intermittent Android build error has been happening for awhile. As far as I can tell, it's some sort of race condition in OpenSSL's custom build process. Running the build again usually fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions thrown in C# can be caught in C++, and exceptions thrown in C++ can be caught in C#. Exceptions thrown in C# can also now safely pass through C++ code to be code in other C# code, and vice-versa.
This is a big improvement because previously:
Fixes #18
It works pretty much just as I described in this comment:
#18 (comment)