Change Windows detection for URI methods. #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of: ``` if constexpr (std::filesystem::path::preferred_separator == '\\')` ``` We now do: ``` ``` Because the former won't work on versions of iOS prior to 13.0.
|
Looks good to me, thanks @kring ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of:
We now do:
#ifdef _WIN32Because the former won't work on versions of iOS prior to 13.0.
See CesiumGS/cesium-unreal#1431
I considered fixing this by ifdef'ing for an old version of iOS specifically, but it would be more complicated and the benefit is vanishingly small.
@csciguy8 originally suggested just using
#ifdef _WIN32here, but I tried to be clever.