Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarfiy what it means to be an alphanumeric identifier #646

Merged
merged 4 commits into from
Mar 4, 2022

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Mar 4, 2022

Follow up to CesiumGS/glTF#60. Includes more strict definition for "alphanumeric identifier".

@lilleyse lilleyse requested a review from javagl March 4, 2022 13:09
Copy link
Contributor

@javagl javagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered whether it could be worth moving the block from ID into an own paragraph like "Identifiers", explain the regex and further constraints there once, and then just link to that from every ID section.

(I could create a draft PR on top of this one, just to see how this could look like)

Also, I wondered if there should be any constraints for Semantic names (maybe not even at https://github.com/CesiumGS/3d-tiles/blob/637e53f2d0af1968b1e0a60a0863fbe2debb2759/specification/Metadata/README.md#semantic , but directly in the semantics docs). The constraints that are described there verbally could be captured in a RegEx as well. (An aside: I thought there was a requirement for "custom" semantics to start with _, but I didn't find it right now...?)

@lilleyse
Copy link
Contributor Author

lilleyse commented Mar 4, 2022

I wondered whether it could be worth moving the block from ID into an own paragraph like "Identifiers", explain the regex and further constraints there once, and then just link to that from every ID section.

(I could create a draft PR on top of this one, just to see how this could look like)

Sure, go for it!

@lilleyse
Copy link
Contributor Author

lilleyse commented Mar 4, 2022

@javagl and I reviewed each other's changes here, merging.

@lilleyse lilleyse merged commit 5367720 into extension-revisions Mar 4, 2022
@lilleyse lilleyse deleted the alphanumeric-clarification branch March 4, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants