Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Mismatching #174

Merged
merged 2 commits into from
Feb 7, 2017
Merged

Type Mismatching #174

merged 2 commits into from
Feb 7, 2017

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Jan 31, 2017

This PR makes the styling language stricter about types and less reliant on JavaScript conventions.

  • Removed != and ==
  • Added a section about operator rules. Specifies which operators accept which types
  • Added a section about string conversions.
  • Added the Array type to more areas, I think it was just oversight that it was missing before
  • Removed Matrix types from batch table binary - they were never implemented in the shader backend in Cesium and I can't think of a great use case for them anymore

Cesium implementation : CesiumGS/cesium#4860 and CesiumGS/cesium#4940

@pjcozzi pjcozzi added the styling label Feb 5, 2017
@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 5, 2017

All looks good, just one question: remind me where arrays are currently used in practice?

@lilleyse
Copy link
Contributor Author

lilleyse commented Feb 7, 2017

They are allowed as properties in the batch table json. Otherwise they aren't used for any special purposes.

@pjcozzi pjcozzi merged commit 928cb68 into master Feb 7, 2017
@pjcozzi pjcozzi deleted the type-mismatch branch February 7, 2017 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants