Optimize b3dm #30

lasalvavida · 2016-11-11T21:58:19Z

Adds a tool for optimizing individual b3dm files with gltf-pipeline. The binary glTF is extracted, processed, and then placed back with the header and batch table.

Depends on: CesiumGS/gltf-pipeline#183.

To try this now, manually copy the expose-argument-parsing branch of gltf-pipeline into your node_modules. Currently package.json is set to depend on the next release, so this can be merged when that happens.

pjcozzi · 2016-11-14T22:26:42Z

tools/lib/optimizeB3dm.js

+ * @param {Object} [options] Options specifying custom gltf-pipeline behavior.
+ * @returns {Buffer} The optimized b3dm buffer.
+ */
+function optimizeB3dm(buffer, options) {


Can we separate this into explicit functions:

b3dm to glTF (and provide this as a command-line tool)

Running gltf-pipeline

glTF to b3dm (and provide this as a command-line tool)

There should be an option to pass in the parameters needed for the header and batch table

pjcozzi · 2016-11-14T22:27:56Z

tools/README.md

+### optimizeB3dm
+
+Optimize a b3dm using [gltf-pipeline](https://github.com/AnalyticalGraphicsInc/gltf-pipeline/blob/master/README.md). Since this tool does not
+process an entire tileset, it cannot be used with the Pipeline tool.


@lilleyse can you add to the roadmap a traversal utility that can be used to apply per-tile stages like this to all tiles in a tileset?

Ah yes, I can add that to the roadmap.

lilleyse · 2016-11-16T17:22:34Z

By the way, @lasalvavida you should have write access now to this repo.

lilleyse · 2016-11-16T18:18:53Z

tools/README.md

+
+Quantize floating-point attributes and oct-encode normals
+```
+node ./bin/3d-tiles-tools.js optimizeB3dm -i ./specs/data/batchedWithBatchTable.b3dm -o ./output/optimized.b3dm --options -q -n


These two should reference batchedWithBatchTableBinary.b3dm right?

lilleyse · 2016-11-16T18:19:01Z

tools/bin/3d-tiles-tools.js

-    readGlbWriteB3dm(input, force, argv);
+    readGlbWriteB3dm(input, output, force);
+} else if (command === 'optimizeB3dm') {
+    // optimizeB3dm is not a pipeline tool, so handle it separately.


Factor this whole section into its own function.

lilleyse · 2016-11-16T18:19:32Z

tools/bin/3d-tiles-tools.js

+        optionArgs.push('null');
+        options = GltfPipeline.parseArguments(optionArgs);
+    }
+    output = defaultValue(output, input.slice(0, input.length - 4) + 'b3dm');


The default path here will be equal to the input path.

lilleyse · 2016-11-16T18:19:41Z

tools/lib/optimizeB3dm.js

+module.exports = optimizeB3dm;
+
+/**
+ * Given an input, possibly gzipped buffer containing a b3dm, optimize it using gltf-pipeline with the provided options


I think it would make more sense for the potential unzip to happen the bin file instead.

lilleyse · 2016-11-16T18:19:51Z

tools/specs/lib/optimizeB3dmSpec.js

+                expect(header.readUInt32LE(8)).toEqual(optimizedBuffer.length);
+                expect(header.readUInt32LE(12)).toEqual(batchTableJSONByteLength);
+                expect(header.readUInt32LE(16)).toEqual(batchTableBinaryByteLength);
+                expect(header.readUInt32LE(20)).toEqual(batchLength);


Can you also check here that the gltf content was modified in some way. Even just comparing buffers is ok.

lilleyse · 2016-11-16T18:24:21Z

Seems like a possible gltf-pipeline issue - I'm running the command

node ./bin/3d-tiles-tools.js optimizeB3dm -i ./specs/data/batchedWithBatchTableBinary.b3dm -o ./output/optimized.b3dm

And getting this result:

lilleyse · 2016-11-16T18:37:43Z

CesiumGS/gltf-pipeline#183 is merged now. Once the above issue is resolved I'll publish gltf-pipeline to npm.

lasalvavida · 2016-11-18T15:46:42Z

batchedWithBatchTableBinary.b3dm has oct-encoded normals which gltf-pipeline currently cannot process. Blowing out the normals with -r -f yields the expected result.

lilleyse · 2016-11-18T16:01:31Z

batchedWithBatchTableBinary.b3dm has oct-encoded normals which gltf-pipeline currently cannot process. Blowing out the normals with -r -f yields the expected result.

Ah, that explains it. Let's use this one instead that doesn't have oct-encoded normals
batchedWithBatchTableBinary.b3dm.txt

lilleyse · 2016-11-18T16:02:23Z

Also given that, I'm going to publish gltf-pipeline to npm now.

lilleyse · 2016-11-18T16:18:41Z

Ready now.

lasalvavida · 2016-11-18T17:21:57Z

@lilleyse Updated with the requested changes.

lilleyse · 2016-12-02T18:16:17Z

For #34

Perhaps some explicit tools for b3dm->glb and i3dm->glb will be needed in another PR, but all the glb extraction code is here.

lilleyse · 2016-12-02T18:38:14Z

tools/bin/3d-tiles-tools.js

+        optionArgs.push('null');
+        options = GltfPipeline.parseArguments(optionArgs);
+    }
+    outputPath = defaultValue(outputPath, inputPath);


Instead of overwriting if no output path is given, it should add a suffix to the filename, like batchedWithBatchTableBinary-optimized.b3dm

lilleyse · 2016-12-02T18:41:10Z

tools/lib/extractB3dm.js

+            batchLength : batchLength
+        },
+        batchTable : {
+            JSON : batchTableJSONBuffer,


Maybe json instead.

lilleyse · 2016-12-02T18:45:37Z

Sorry about the delay - but everything looks great.

…into optimizeB3dm

lasalvavida · 2016-12-05T17:53:50Z

@lilleyse, updated.

pjcozzi · 2016-12-05T23:21:31Z

We should also do this for i3dm, but it is not priority now and a good beginner issue so I submitted #36.

lasalvavida · 2016-12-08T06:25:44Z

@lilleyse Can you look at this when you get a chance?

lilleyse · 2016-12-12T22:29:24Z

The changes look good!

lasalvavida added 4 commits November 11, 2016 16:08

Added optimizeB3dm tool

2284383

Added tests and fixed failing tests from gzip change

b1fcade

Updated README

0480a71

Depend on next release of gltf-pipeline

7b0dec8

pjcozzi reviewed Nov 14, 2016

View reviewed changes

pjcozzi mentioned this pull request Oct 3, 2022

3D Tiles Tools roadmap CesiumGS/3d-tiles-tools#9

Open

11 tasks

Webstorm update

37a3ae0

lilleyse reviewed Nov 16, 2016

View reviewed changes

lasalvavida added 2 commits November 18, 2016 12:20

Separated tools out and added b3dmToGlb

b067947

Updated README

e8a93b1

lilleyse reviewed Dec 2, 2016

View reviewed changes

Fixes

83ea561

lasalvavida added 2 commits December 5, 2016 12:48

Small tweaks

32f67d1

Updated outputPath default and switched JSON property to json

7e68a3b

Merge branch 'optimizeB3dm' of github.com:lasalvavida/3d-tiles-tools …

4053bec

…into optimizeB3dm

lilleyse merged commit 8ca7dfc into CesiumGS:master Dec 12, 2016

pjcozzi mentioned this pull request Jan 12, 2017

b3dm/i3dm to glb #34

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimize b3dm #30

Optimize b3dm #30

lasalvavida commented Nov 11, 2016 •

edited

Loading

pjcozzi Nov 14, 2016

pjcozzi Nov 14, 2016

lilleyse Nov 14, 2016

lilleyse commented Nov 16, 2016

lilleyse Nov 16, 2016

lilleyse Nov 16, 2016

lilleyse Nov 16, 2016

lilleyse Nov 16, 2016

lilleyse Nov 16, 2016

lilleyse commented Nov 16, 2016 •

edited

Loading

lilleyse commented Nov 16, 2016

lasalvavida commented Nov 18, 2016

lilleyse commented Nov 18, 2016

lilleyse commented Nov 18, 2016

lilleyse commented Nov 18, 2016

lasalvavida commented Nov 18, 2016 •

edited

Loading

lilleyse commented Dec 2, 2016 •

edited

Loading

lilleyse Dec 2, 2016

lilleyse Dec 2, 2016

lilleyse commented Dec 2, 2016

lasalvavida commented Dec 5, 2016

pjcozzi commented Dec 5, 2016

lasalvavida commented Dec 8, 2016

lilleyse commented Dec 12, 2016

Optimize b3dm #30

Optimize b3dm #30

Conversation

lasalvavida commented Nov 11, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lilleyse commented Nov 16, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lilleyse commented Nov 16, 2016 • edited Loading

lilleyse commented Nov 16, 2016

lasalvavida commented Nov 18, 2016

lilleyse commented Nov 18, 2016

lilleyse commented Nov 18, 2016

lilleyse commented Nov 18, 2016

lasalvavida commented Nov 18, 2016 • edited Loading

lilleyse commented Dec 2, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lilleyse commented Dec 2, 2016

lasalvavida commented Dec 5, 2016

pjcozzi commented Dec 5, 2016

lasalvavida commented Dec 8, 2016

lilleyse commented Dec 12, 2016

lasalvavida commented Nov 11, 2016 •

edited

Loading

lilleyse commented Nov 16, 2016 •

edited

Loading

lasalvavida commented Nov 18, 2016 •

edited

Loading

lilleyse commented Dec 2, 2016 •

edited

Loading