Code

Certora Review#7

Code

Open

MichaelMorami wants to merge 129 commits intomainCertora/aave-v3-origin:mainfrom certoraCertora/aave-v3-origin:certoraCopy head branch name to clipboard

+2,199-3,151

Commits

Commits on Sep 15, 2024

• Certora Report After Reintroduction Of Permissioned Rescue

  MichaelMorami

  committed
  70b1e2c

  Copy full SHA for 70b1e2c

Commits on Sep 19, 2024

• Merge remote-tracking branch 'bgd-labs/v3.2.0' into certora

  nisnislevi

  committed
  6345f33

  Copy full SHA for 6345f33

Commits on Sep 22, 2024

• Merge remote-tracking branch 'bgd-labs/v3.2.0' into certora

  nisnislevi

  committed
  9297533

  Copy full SHA for 9297533

Commits on Sep 23, 2024

• update stata to fit the new directories arrangment of the solidity

  nisnislevi

  committed
  63a2cc3

  Copy full SHA for 63a2cc3

• re-organization of the basic rules

  nisnislevi

  committed
  3a199ba

  Copy full SHA for 3a199ba

• Merge remote-tracking branch 'bgd-labs/v3.2.0' into certora

  nisnislevi

  committed
  03ac790

  Copy full SHA for 03ac790

• fix bug in conf

  nisnislevi

  committed
  0deedec

  Copy full SHA for 0deedec

• fix yml

  nisnislevi

  committed
  ccabc06

  Copy full SHA for ccabc06

• fix yml again

  nisnislevi

  committed
  44bd40d

  Copy full SHA for 44bd40d

• fix yml again

  nisnislevi

  committed
  67b7e19

  Copy full SHA for 67b7e19

• add the get/set rules for EMode

  nisnislevi

  committed
  f04eef0

  Copy full SHA for f04eef0

Commits on Sep 30, 2024

• Merge remote-tracking branch 'bgd-labs/main' into certora

  nisnislevi

  committed
  0795456

  Copy full SHA for 0795456

• add to pool-harness: getConfiguration

  nisnislevi

  committed
  9fcfd66

  Copy full SHA for 9fcfd66

• add to pool-harness: getVirtualUnderlyingBalance

  nisnislevi

  committed
  3e5648f

  Copy full SHA for 3e5648f

Commits on Oct 6, 2024

• some fixes

  nisnislevi

  committed
  cc658f6

  Copy full SHA for cc658f6

• Merge branch 'certora-squashed' into certora

  nisnislevi

  committed
  c0b7228

  Copy full SHA for c0b7228

Commits on Oct 16, 2024

• fix: apply gas & codesize savings

  sakulstra

  committed
  bff7ce3

  Copy full SHA for bff7ce3

• refactor: aggregator interface cleanup

  sakulstra

  committed
  969ee04

  Copy full SHA for 969ee04

• perf: optimize bitmap for access instead of writes

  sakulstra

  committed
  1b56764

  Copy full SHA for 1b56764

• feat: deficit tracking and excess debt removal (aave-dao#61)

  Show description for 9302038
  

  ianflexa

  and

  sakulstra

  committed
  9302038

  Copy full SHA for 9302038

• fix: patch imports

  sakulstra

  committed
  2ea3e77

  Copy full SHA for 2ea3e77

• feat: getReserveAToken getter (aave-dao#64)

  sakulstra

  committed
  7e582b0

  Copy full SHA for 7e582b0

• docs: refine docs (aave-dao#67)

  Show description for 802924b
  sakulstra

  committed
  802924b

  Copy full SHA for 802924b

• fix: access cache not storage (aave-dao#68)

  Show description for f5389a4
  sakulstra

  committed
  f5389a4

  Copy full SHA for f5389a4

• chore: add comment in _burnBadDebt + lint

  

  ianflexa

  authored and

  sakulstra

  committed
  c4c438e

  Copy full SHA for c4c438e

• feat: use addresses provider instead of acl (aave-dao#66)

  Show description for 26b632d
  sakulstra

  committed
  26b632d

  Copy full SHA for 26b632d

• fix: use cache.lastUpdatedTimestamp (aave-dao#70)

  sakulstra

  committed
  da89365

  Copy full SHA for da89365

• fix: debt cleanup review & liquidation improvements (aave-dao#69)

  Show description for 95bf29b
  sakulstra

  committed
  95bf29b

  Copy full SHA for 95bf29b

• refactor: improvements (aave-dao#82)

  Show description for 6e4a93b
  sakulstra

  authored
  6e4a93b

  Copy full SHA for 6e4a93b

• fix: add note about breaking change

  sakulstra

  committed
  ae74fad

  Copy full SHA for ae74fad

Commits on Oct 17, 2024

• refactor: reuse _burnDebt (aave-dao#83)

  Show description for 07c1da7
  

  kyzia551

  and

  sakulstra

  authored
  07c1da7

  Copy full SHA for 07c1da7

Commits on Oct 21, 2024

• feat: make weth and pool public for easier validation (aave-dao#85)

  sakulstra

  authored
  f910b01

  Copy full SHA for f910b01

Commits on Oct 22, 2024

• Merge remote-tracking branch 'bgd-labs/main' into certora

  nisnislevi

  committed
  51c3f44

  Copy full SHA for 51c3f44

• docs: 3.3 docs & GHO improvements (aave-dao#84)

  Show description for dd00c6a
  

  sakulstra

  and

  eboadom

  authored
  dd00c6a

  Copy full SHA for dd00c6a

• fix: remove incomplete properties

  sakulstra

  committed
  0c6fac8

  Copy full SHA for 0c6fac8

Commits on Oct 23, 2024

• finding: remove unused error

  sakulstra

  committed
  0e195bb

  Copy full SHA for 0e195bb

• finding: Validationlogic was imported but never used

  sakulstra

  committed
  95fc118

  Copy full SHA for 95fc118

• finding: unnecessary calculations in LiquiationLogic

  sakulstra

  committed
  a473403

  Copy full SHA for a473403

• fix: allow 100% vf liquidations if collateral is below threshold

  sakulstra

  committed
  69baa1d

  Copy full SHA for 69baa1d

• fix: add test for 100% close factor

  sakulstra

  committed
  677173c

  Copy full SHA for 677173c

Commits on Oct 24, 2024

• fix: resolve conflicts

  sakulstra

  committed
  027aaed

  Copy full SHA for 027aaed

• Merge branch 'stermi/unused-import' into v3.3.3-certora

  sakulstra

  committed
  21f2616

  Copy full SHA for 21f2616

• Merge branch 'stermi/unused-error' into v3.3.3-certora

  sakulstra

  committed
  86d07df

  Copy full SHA for 86d07df

• finding: not considering fee when validating min_leftover

  sakulstra

  committed
  a223bed

  Copy full SHA for a223bed

• fix: conflicts

  sakulstra

  committed
  57411c9

  Copy full SHA for 57411c9

Commits on Oct 29, 2024

• finding: unnecessary IAccessControl import

  sakulstra

  committed
  b1f7f58

  Copy full SHA for b1f7f58

• finding: misc natspec issues

  sakulstra

  committed
  17444f6

  Copy full SHA for 17444f6

• fix: apply stermies suggestions to eliminateReserveDeficit

  sakulstra

  committed
  8fe1aa6

  Copy full SHA for 8fe1aa6

• fix: improve tests

  sakulstra

  committed
  c21a2d2

  Copy full SHA for c21a2d2

• fix: remove obsolete comment

  sakulstra

  committed
  5e489ba

  Copy full SHA for 5e489ba

• fix: move is collateral logic

  sakulstra

  committed
  cd4d59d

  Copy full SHA for cd4d59d

• finding: cache lastUpdated

  sakulstra

  committed
  d4ae764

  Copy full SHA for d4ae764

• fix: dont disable collateral

  Show description for ab8066b
  sakulstra

  committed
  ab8066b

  Copy full SHA for ab8066b

Commits on Oct 31, 2024

• fix: call handleRepayment when clearing deficit

  sakulstra

  committed
  a2180ee

  Copy full SHA for a2180ee

• fix: gho accounting

  sakulstra

  committed
  181577b

  Copy full SHA for 181577b

• fix: docs

  sakulstra

  committed
  3aaee60

  Copy full SHA for 3aaee60

• fix: logic patch

  sakulstra

  committed
  dbfd840

  Copy full SHA for dbfd840

• fix: comment out test as doesn't make sense with the mock

  sakulstra

  committed
  3fba8d0

  Copy full SHA for 3fba8d0

• test: add tests

  sakulstra

  committed
  4f101ba

  Copy full SHA for 4f101ba

• fix: add comment

  sakulstra

  committed
  05a2b55

  Copy full SHA for 05a2b55

Commits on Nov 4, 2024

• sync to new EModeConfiguration.spec

  nisnislevi

  committed
  f344197

  Copy full SHA for f344197

• Merge branch 'audit/certora-3.3.0' into certora

  nisnislevi

  committed
  6f9c5f7

  Copy full SHA for 6f9c5f7

• Update src/contracts/protocol/libraries/logic/LiquidationLogic.sol

  Show description for 2d5ec46
  

  sakulstra

  and

  eboadom

  authored
  2d5ec46

  Copy full SHA for 2d5ec46

• fix: suppl 1 wei surplus

  sakulstra

  committed
  73a23b9

  Copy full SHA for 73a23b9

• updating the rules for 3.3

  nisnislevi

  committed
  f340a75

  Copy full SHA for f340a75

• in yml: move to certora-cli=7.17.2

  nisnislevi

  committed
  c39cff3

  Copy full SHA for c39cff3

Commits on Nov 5, 2024

• fix: remove non functional test

  sakulstra

  committed
  ffe466d

  Copy full SHA for ffe466d

Commits on Nov 6, 2024

• Update src/contracts/protocol/libraries/logic/LiquidationLogic.sol

  Show description for 104a288
  

  sakulstra

  and

  eboadom

  authored
  104a288

  Copy full SHA for 104a288

• Update src/contracts/protocol/libraries/logic/LiquidationLogic.sol

  Show description for b516363
  

  sakulstra

  and

  eboadom

  authored
  b516363

  Copy full SHA for b516363

• docs: add explanatory comment

  sakulstra

  committed
  5ca633b

  Copy full SHA for 5ca633b

• refactor: better remove test

  sakulstra

  committed
  0b21084

  Copy full SHA for 0b21084

• fix: clearify it's the interest on the bad debt only

  sakulstra

  committed
  707d652

  Copy full SHA for 707d652

• docs: add a sentence to docs

  sakulstra

  committed
  1eb834b

  Copy full SHA for 1eb834b

• docs: improve docs

  sakulstra

  committed
  d45702a

  Copy full SHA for d45702a

• Merge branch 'main' into certora

  nisnislevi

  committed
  ab07809

  Copy full SHA for ab07809

• small fix due to failure in CI

  nisnislevi

  committed
  a07d6c7

  Copy full SHA for a07d6c7

• for PR

  nisnislevi

  committed
  8c66ac7

  Copy full SHA for 8c66ac7

Commits on Nov 13, 2024

• fix: dont disable collateral alternative

  sakulstra

  committed
  bacdbf0

  Copy full SHA for bacdbf0

Commits on Nov 14, 2024

• working on solvency for LiquidationCAll

  nisnislevi

  committed
  b67fa3c

  Copy full SHA for b67fa3c

Commits on Nov 18, 2024

• Merge branch 'stermi/IAccessControl' into v3.3.0

  sakulstra

  committed
  905ade8

  Copy full SHA for 905ade8

• Merge branch 'stermi/natspec' into v3.3.0

  sakulstra

  committed
  9cfb2fc

  Copy full SHA for 9cfb2fc

• Merge branch 'fix/cache-lastUpdated' into v3.3.0

  sakulstra

  committed
  e2315b3

  Copy full SHA for e2315b3

• Merge branch 'fix/dont-disable-collateral-alternative' into v3.3.0

  sakulstra

  committed
  d9450ad

  Copy full SHA for d9450ad

• docs: clearify docs

  sakulstra

  committed
  38e0b15

  Copy full SHA for 38e0b15

• fix: address comments by stermi

  Show description for 2a59531
  sakulstra

  committed
  2a59531

  Copy full SHA for 2a59531

• fix: resolve conflicts

  sakulstra

  committed
  91ed89b

  Copy full SHA for 91ed89b

• Merge branch 'fix/call-handleRepayment-when-clearing-deficit' into v3.3.0

  sakulstra

  committed
  9d0ee8d

  Copy full SHA for 9d0ee8d

• fix: resolve conflicts

  sakulstra

  committed
  ddb3ad0

  Copy full SHA for ddb3ad0

• lint: lint markdown

  sakulstra

  committed
  e741c4d

  Copy full SHA for e741c4d

• fixing fv failures after code update

  MichaelMorami

  committed
  ebd958b

  Copy full SHA for ebd958b

• Merge branch 'certora-squashed' into certora

  MichaelMorami

  committed
  44ca6db

  Copy full SHA for 44ca6db

• fixing fv failures after code update (aave-dao#76)

  MichaelMorami

  authored
  4b8ab37

  Copy full SHA for 4b8ab37

Commits on Nov 19, 2024

• fix: harness

  sakulstra

  committed
  4e79789

  Copy full SHA for 4e79789

• fix: patch harness

  sakulstra

  committed
  6db6f6e

  Copy full SHA for 6db6f6e

Commits on Nov 20, 2024

• Merge remote-tracking branch 'origin/certora-squashed' into certora-squashed

  nisnislevi

  committed
  5f6b1de

  Copy full SHA for 5f6b1de

• Merge branch 'certora-squashed' into certora

  nisnislevi

  committed
  7e56424

  Copy full SHA for 7e56424

• Merge branch 'certora-patch' into certora

  nisnislevi

  committed
  10b8bdb

  Copy full SHA for 10b8bdb

• remove rule_sanity from 4 rules, and move to 7.17.2

  nisnislevi

  committed
  a57b013

  Copy full SHA for a57b013

• end of 20/11

  nisnislevi

  committed
  9d3383a

  Copy full SHA for 9d3383a

• fix: resolve conflicts

  sakulstra

  committed
  d3bf92e

  Copy full SHA for d3bf92e

• fix: properly resolve conflicts

  sakulstra

  committed
  af4bfb0

  Copy full SHA for af4bfb0

• fix: adjust to new rescuable

  sakulstra

  committed
  3008691

  Copy full SHA for 3008691

Commits on Nov 21, 2024

• before updating to the fixed 3.3

  nisnislevi

  committed
  1918263

  Copy full SHA for 1918263

• before updating to the fixed 3.3

  nisnislevi

  committed
  b5a01ec

  Copy full SHA for b5a01ec

• Merge branch 'v3.3.0' into pool-solvency

  nisnislevi

  committed
  61885f9

  Copy full SHA for 61885f9

Commits on Nov 24, 2024

• end of 24/11

  nisnislevi

  committed
  37f118f

  Copy full SHA for 37f118f

Commits on Nov 25, 2024

• end of 25/11

  nisnislevi

  committed
  1101d98

  Copy full SHA for 1101d98

• refactor: move logic to liquidationlogic (#122)

  sakulstra

  authored
  8b94bae

  Copy full SHA for 8b94bae

Commits on Nov 26, 2024

• docs: add properties (aave-dao#94)

  sakulstra

  authored
  b21b164

  Copy full SHA for b21b164

• fix: func visibility (#123)

  brotherlymite

  authored
  38b0cdd

  Copy full SHA for 38b0cdd

Commits on Nov 27, 2024

• Fix: validationLogic and BridgeLogic titles (#127)

  Show description for 12e529b
  ianflexa

  authored
  12e529b

  Copy full SHA for 12e529b

• fix: filtering reserves aTokens (#128)

  ianflexa

  authored
  0160ab5

  Copy full SHA for 0160ab5

• Merge branch 'main' into v3.3.0

  sakulstra

  committed
  784d7f3

  Copy full SHA for 784d7f3

Commits on Nov 28, 2024

• end of 28.11

  nisnislevi

  committed
  bc5ec02

  Copy full SHA for bc5ec02

Commits on Dec 1, 2024

• add directory certora/solvency

  nisnislevi

  committed
  d15e4dd

  Copy full SHA for d15e4dd

Commits on Dec 4, 2024

• trying alpha-master

  nisnislevi

  committed
  56363df

  Copy full SHA for 56363df

Commits on Dec 9, 2024

• docs: update example to not overlap with other mechanics

  sakulstra

  committed
  7aabb1b

  Copy full SHA for 7aabb1b

Commits on Dec 10, 2024

• fix: rsolve conflicts

  sakulstra

  committed
  80d3454

  Copy full SHA for 80d3454

• fix: consider deficit as part of unbacked

  Show description for 1fa3d57
  sakulstra

  committed
  1fa3d57

  Copy full SHA for 1fa3d57

Commits on Dec 11, 2024

• Update src/contracts/interfaces/IPool.sol

  Show description for 002a2b1
  

  sakulstra

  and

  miguelmtzinf

  authored
  002a2b1

  Copy full SHA for 002a2b1

• chore: bump revisions fix typos (aave-dao#41)

  Show description for 487f19a
  sakulstra

  authored
  487f19a

  Copy full SHA for 487f19a

• Apply suggestions from code review

  Show description for 385287d
  

  sakulstra

  and

  miguelmtzinf

  authored
  385287d

  Copy full SHA for 385287d

Commits on Dec 12, 2024

• closing pool-solvency work before moving to public repo

  nisnislevi

  committed
  28d1cde

  Copy full SHA for 28d1cde

• Merge remote-tracking branch 'bgd-public/v3.3.0' into certora

  nisnislevi

  committed
  bfdf50b

  Copy full SHA for bfdf50b

• Merge remote-tracking branch 'certora-private/pool-solvency' into certora

  nisnislevi

  committed
  7871726

  Copy full SHA for 7871726

• cli vertion to 7.20.3

  nisnislevi

  committed
  976577d

  Copy full SHA for 976577d

• remove solvency files, and prepare for PR

  nisnislevi

  committed
  ecc0cd6

  Copy full SHA for ecc0cd6

• cosmetics in .yml

  nisnislevi

  committed
  2750091

  Copy full SHA for 2750091

• fix nonpassing tests

  nisnislevi

  committed
  5985a89

  Copy full SHA for 5985a89