Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support fields aliases #177

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Support fields aliases #177

merged 2 commits into from
Nov 4, 2024

Conversation

vklachkov
Copy link
Contributor

This PR adds support for aliases in the Typed derive macro. The syntax is identical to aliases in serde

@vklachkov vklachkov mentioned this pull request Oct 31, 2024
Open
CertainLach
CertainLach requested changes Nov 3, 2024
View reviewed changes
Copy link
Owner

@CertainLach CertainLach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that original single method implementation is better here, as implementation is very similar, and it is easier to see a difference when it is handled for individual parts

crates/jrsonnet-macros/src/lib.rs Outdated Show resolved Hide resolved
crates/jrsonnet-macros/src/lib.rs Outdated Show resolved Hide resolved
@CertainLach CertainLach merged commit a9a2382 into CertainLach:master Nov 4, 2024
1 of 4 checks passed
@vklachkov vklachkov deleted the aliases branch November 5, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CertainLach CertainLach CertainLach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vklachkov @CertainLach