Skip to content

Commit

Permalink
test,doc,sea: run SEA tests on ppc64
Browse files Browse the repository at this point in the history
The recent Postject upgrade, nodejs#48072,
included a performance improvement for the injection operation
(see nodejs/postject#86), so now it might be
possible to run the SEA tests on the ppc64 architecture runners on
Jenkins, which was previously getting timed out.

Signed-off-by: Darshan Sen <[email protected]>
PR-URL: nodejs#48111
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
  • Loading branch information
RaisinTen authored and Ceres6 committed Aug 14, 2023
1 parent 6a29340 commit fff5bf3
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion doc/api/single-executable-applications.md
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ platforms:
* Windows
* macOS
* Linux (all distributions [supported by Node.js][] except Alpine and all
architectures [supported by Node.js][] except s390x and ppc64)
architectures [supported by Node.js][] except s390x)
This is due to a lack of better tools to generate single-executables that can be
used to test this feature on other platforms.
Expand Down
4 changes: 0 additions & 4 deletions test/common/sea.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ function skipIfSingleExecutableIsNotSupported() {
if (process.arch === 's390x') {
common.skip('On s390x, postject fails with `memory access out of bounds`.');
}

if (process.arch === 'ppc64') {
common.skip('On ppc64, this test times out.');
}
}
}

Expand Down

0 comments on commit fff5bf3

Please sign in to comment.