url: fix isURL detection by checking path

Fixes: nodejs#48921 PR-URL: nodejs#48928 Fixes: getsentry/sentry-javascript#8552 Fixes: request/request#3458 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Ceres6 · Aug 14, 2023 · 14c7b51 · 14c7b51
1 parent 2fd05cb
commit 14c7b51
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -753,13 +753,13 @@ ObjectDefineProperties(URLSearchParams.prototype, {
  * We use `href` and `protocol` as they are the only properties that are
  * easy to retrieve and calculate due to the lazy nature of the getters.
  *
- * We check for auth attribute to distinguish legacy url instance with
+ * We check for `auth` and `path` attribute to distinguish legacy url instance with
  * WHATWG URL instance.
  * @param {*} self
  * @returns {self is URL}
  */
 function isURL(self) {
-  return Boolean(self?.href && self.protocol && self.auth === undefined);
+  return Boolean(self?.href && self.protocol && self.auth === undefined && self.path === undefined);
 }
 
 class URL {

diff --git a/test/parallel/test-url-is-url.js b/test/parallel/test-url-is-url.js
@@ -9,3 +9,8 @@ const { isURL } = require('internal/url');
 
 assert.strictEqual(isURL(new URL('https://www.nodejs.org')), true);
 assert.strictEqual(isURL(parse('https://www.nodejs.org')), false);
+assert.strictEqual(isURL({
+  href: 'https://www.nodejs.org',
+  protocol: 'https:',
+  path: '/',
+}), false);