Skip to content

Commit

Permalink
Rollup merge of rust-lang#60697 - hellow554:fix_60629, r=michaelwoeri…
Browse files Browse the repository at this point in the history
…ster

add regression test for rust-lang#60629

This bug was fixed, but I don't know which one. (I think it even doesn't matter at all).

Added a regression test.

```
op@OP ~/m/r/s/t/incremental> rustc --version
rustc 1.35.0-nightly (acd8dd6 2019-04-05)
op@OP ~/m/r/s/t/incremental> rustc -C incremental= --cfg rpass1 issue-60629.rs
warning: struct is never constructed: `A`
 --> issue-60629.rs:3:1
  |
3 | struct A;
  | ^^^^^^^^^
  |
  = note: #[warn(dead_code)] on by default

op@OP ~/m/r/s/t/incremental> rustc -C incremental= --cfg rpass2 issue-60629.rs
error: internal compiler error: src/librustc/ty/query/plumbing.rs:1195: Cannot force dep node: coherent_trait(core[c27c]::ops[0]::drop[0]::Drop[0])

thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:635:9
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
error: aborting due to previous error

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.35.0-nightly (acd8dd6 2019-04-05) running on x86_64-unknown-linux-gnu

note: compiler flags: -C incremental
```

with latest nightly it does not crash anymore, so nothing more to do.

Fixes rust-lang#60629

(accidentally removed the remote branch on github, therefore GH closed the other PR.)

r? @nikomatsakis
  • Loading branch information
Centril authored May 10, 2019
2 parents ec6afb1 + c81780b commit 0b63f55
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions src/test/incremental/issue-60629.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// revisions:rpass1 rpass2

struct A;

#[cfg(rpass2)]
impl From<A> for () {
fn from(_: A) {}
}

fn main() {}

0 comments on commit 0b63f55

Please sign in to comment.