[ENG-6825] make gv helpers less storage-centric #10887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Include computing addons in the addons list from gravyvalet. * Suport other addon types when fetching wb credentials. [ENG-6825]
felliott
force-pushed
the
feature/gravyboa-submission
branch
from
f90aafa to
7e6eae9
Compare
adlius
approved these changes
Jan 6, 2025
felliott
merged commit 82ef3f6
into
CenterForOpenScience:feature/gravy_valet_integration
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Enable submission of jobs to boa by correctly pulling creds from GV.
Changes
Include computing addons in the addons list from gravyvalet.
Support other addon types when fetching wb credentials.
QA Notes
Should enable remainder testing of gravyboa.
Documentation
Nope.
Side Effects
None expected.
Ticket
ENG-6825