[WIP][ENG-5213] - Updated usage of osf:develop and Python 3.10 support #10540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felliott
requested changes
Feb 8, 2024
There was a problem hiding this comment.
Looks good, @ly-mariia! I just thought of something that was mentioned in the original ticket. Since we would like to do another dep upgrade for python 3.11 soon, it would be nice if we could go back to our old deps with out having to rebuild requirements entirely. Could you rename the requirements volume to have 3.10 somewhere in the name? Something like osf_requirements_3_10_vol. If we start working on the 3.11 upgrade and have to switch back b/c QA finds a bug in the 3.10 code, we can just s/osf_requirements_3_11_vol/osf_requirements_3_10_vol/ instead of rebuilding.
ly-mariia
changed the title
- Updated requirements.txt to support Python 3.10
* The elasticsearch deps are tied to the version of the es service being run. Revert back to the previous dep until we can upgrade es. * Make a new volume for 3.10 deps. While working on this project, this will make switching back to the old 3.6 based version easier (just swap which volumes are commented).
felliott
merged commit d467dbe
into
CenterForOpenScience:feature/python-upgrade
1 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Phase 1
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-5213