[ENG-5224] Unit Tests for Cedar Metadata Backend API - Part 2 #10534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslzchen
force-pushed
the
feature/eng-5224-unit-tests
branch
from
86d5f6f to
62a1293
Compare
* Only write/admin can create, otherwise raise 403 * Creating record with inactive tempaltes will raise 404
* No auth -> 401 * Non-contributor or read contributor -> 403 * Inactive template -> 404
4 tasks
* Remove unecessary permission class for list views * Apply similar permission check for related record views in nodes, registration and files
cslzchen
changed the title
cslzchen
force-pushed
the
feature/eng-5224-unit-tests
branch
from
2e7cac7 to
d7d1153
Compare
(when it is a relationship of a public view)
cslzchen
merged commit 9699cd8
into
CenterForOpenScience:feature/cedar-integration
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Unit tests for Cedar backend API
/v2/nodes/,/v2/registrations/,/v2/files/Note: tests cover all combinations below
Changes
See Purpose
QA Notes
N/A
Documentation
N/A
Side Effects
N/A
Ticket
https://openscience.atlassian.net/browse/ENG-5224