[ENG-5206] v1 Profilewebsites added don't end up in NotableDomains #10524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
commented
Jan 30, 2024
Johnetordoff
force-pushed
the
add-v1-social-spam-check
branch
7 times, most recently
from
8ea1cd4 to
2d58396
Compare
Johnetordoff
commented
Feb 8, 2024
| @@ -76,7 +76,7 @@ def get_headers_from_request(req): | |||
| k: v | |||
| for k, v in headers.items() | |||
| } | |||
| headers['Remote-Addr'] = req.remote_addr | |||
| headers['Remote-Addr'] = getattr(req, 'remote_addr', None) | |||
There was a problem hiding this comment.
Because the save and therefore spam check can now happen anywhere including outside the request context.
Johnetordoff
commented
Feb 8, 2024
| @@ -196,7 +196,7 @@ def do_check_spam(self, author, author_email, content, request_headers): | |||
| return | |||
|
|
|||
| request_kwargs = { | |||
| 'remote_addr': request_headers.get('Remote-Addr') or request_headers['Host'], # for local testing | |||
| 'remote_addr': request_headers.get('Remote-Addr') or request_headers.get('Host'), # for local testing | |||
There was a problem hiding this comment.
Because the save and therefore spam check can now happen anywhere including outside the request context.
Johnetordoff
force-pushed
the
add-v1-social-spam-check
branch
from
2d58396 to
250ef11
Compare
Johnetordoff
force-pushed
the
add-v1-social-spam-check
branch
9 times, most recently
from
ae858f9 to
e577e5d
Compare
Johnetordoff
force-pushed
the
add-v1-social-spam-check
branch
3 times, most recently
from
b019888 to
5db1c99
Compare
…orOpenScience/osf.io into add-v1-social-spam-check * 'add-v1-social-spam-check' of https://github.com/CenterForOpenScience/osf.io: move spam check into save method # Conflicts: # osf/models/user.py
Johnetordoff
force-pushed
the
add-v1-social-spam-check
branch
2 times, most recently
from
7aead88 to
976abc8
Compare
Johnetordoff
force-pushed
the
add-v1-social-spam-check
branch
from
976abc8 to
fa2cd31
Compare
mfraezz
requested changes
Feb 12, 2024
Johnetordoff
force-pushed
the
add-v1-social-spam-check
branch
5 times, most recently
from
5caa2a5 to
243f1ff
Compare
Johnetordoff
force-pushed
the
add-v1-social-spam-check
branch
from
243f1ff to
742e34d
Compare
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Mar 14, 2024
into test * 'develop' of https://github.com/CenterForOpenScience/osf.io: (48 commits) [ENG-5282] metrics api docs (CenterForOpenScience#10545) Bump version and update CHANGELOG [ENG-5206] Parse v1 Profilewebsites for NotableDomains (CenterForOpenScience#10524) [EMG-4804] Cedar Project PR - BE (CenterForOpenScience#10498) [ENG-5136] datacite 4.5 (CenterForOpenScience#10529) ENG-5208 (CenterForOpenScience#10522) [ENG-5208]: Fix python bootstrapping in docker build (CenterForOpenScience#10518) [ENG-3696] Make gotoFileEvents always open in new tab (CenterForOpenScience#10482) [ENG-5011] Subject.get_semantic_iri use the iri for a subject's bepress synonym only when it has the same text -- it was instead doing the opposite [ENG-4335] subjects on projects (CenterForOpenScience#10324) fix: multiple funding awards from the same funder (CenterForOpenScience#10512) Add actions to update domain notes Avoid 401 when indexing withdrawn preprints use content instead of sanitized text for spam filter. Update sitemap for preprint routes, file downloads [ENG-4919] Add merge migration [ENG-4823] Add Collection Metadata Options (CenterForOpenScience#10499) Add merge migration Add UNVERIFIED Domain classification [ENG-4823] Add Collection Metadata Options (CenterForOpenScience#10499) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This fixes the issue where v1 social domains weren't being check correctly. We examined just adding another spam check, but decided to expand the checks to "check on save" behavior for users.
Changes
QA Notes
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-5206