[ENG-4959] Classify notable domains as unverified #10501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
force-pushed
the
hotfix-unprocessable-domains
branch
3 times, most recently
from
bc3879c to
56bb516
Compare
Johnetordoff
changed the title
Johnetordoff
force-pushed
the
hotfix-unprocessable-domains
branch
from
56bb516 to
89b37f3
Compare
Johnetordoff
commented
Dec 12, 2023
| @@ -75,7 +78,7 @@ def test_actract_domains__returned_on_error(self): | |||
| with mock.patch.object(spam_tasks.requests, 'head') as mock_head: | |||
| mock_head.side_effect = spam_tasks.requests.exceptions.Timeout | |||
| domains = set(spam_tasks._extract_domains(sample_text)) | |||
| assert domains == {sample_text} | |||
There was a problem hiding this comment.
This is the changed test case, others are just changed to pass the note.
mfraezz
requested changes
Dec 12, 2023
Johnetordoff
force-pushed
the
hotfix-unprocessable-domains
branch
from
4f76074 to
a9a49f2
Compare
jwalz
approved these changes
Dec 14, 2023
|
Squashed into af35c28, consider this merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Create a new varity of NotableDomain Note for timedout domains.
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-4959