Feature/Exclude Drafts from News Feed [PLAT-690] #934
Conversation
| @@ -577,7 +577,7 @@ def serve(self, request): | |||
| self.template = page_template | |||
| return render(request, self.template, { | |||
| 'page': self, | |||
| 'newsArticles': NewsArticle.objects.all().order_by('-date'), | |||
| 'newsArticles': NewsArticle.objects.filter(live=True).order_by('-date'), | |||
There was a problem hiding this comment.
This took me awhile to find...spent some time looking at templates/page/news.html.. I was sure that I needed to just do something like: news_item.live is True. Since this was doing nothing, I spent awhile convinced that my changes just weren't showing up locally. Then I skimmed wagtail docs thinking this must be a setting somewhere. I searched through wagtail bugs sure this must be an issue on their end. I finally found this by just going through the models.
Should we add a ticket to audit which code is unused in this codebase and either delete or mark as obsolete? I wasted a lot of time just trying to find this file.
There was a problem hiding this comment.
Oh wow, good catch.
I don't think it's worth doing a full audit of the codebase at this time; for now, I think we can just clean litter up as we find it (Boy Scout Rule).
Btw, I've removed the unused template.
Purpose
News articles drafts show up in news feed
Changes
Update query to fetch NewsArticles where live=True.
Before
Test draft shows up
After
Only "live" articles displayed in feed
Ticket
https://openscience.atlassian.net/browse/PLAT-690