This repository has been archived by the owner on May 26, 2020. It is now read-only.
Fix building on Catalina #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes building on Catalina. Refer to this discussion on electron-builder for why: electron-userland/electron-builder#3990
|
@Hazzard13 I haven't touched this repo in months and I don't plan on doing so anytime soon. This was the same issue I had with OJD builds for OSX post Mojave. Feel free to fork and fix on your own but this repo is unsupported and even I don't use it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a memory error in this version of electron-builder in Mac OS Catalina. To circumvent this without getting stuck in the weeds of updating electron, we can just change the mac build target to zip.
Refer to this discussion on electron-builder for details:
electron-userland/electron-builder#3990