Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to model_selection, GridSearchCV and LineSearchCV #58

Merged
merged 6 commits into from
Jan 11, 2023

Conversation

lbluque
Copy link
Collaborator

@lbluque lbluque commented Jan 10, 2023

Summary

  • rename 'optimizer.py' to 'model_selection.py' to follow scikit-learn more closely.
  • rename GridSearch to GridSeachCV for more explicit naming.
  • rename GridSearch to LineSeachCV for more explicit naming.

Checklist

@lbluque lbluque requested a review from qchempku2017 January 10, 2023 21:10
Copy link
Collaborator

@qchempku2017 qchempku2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer not to rename these classes because these classes are not only implemented to use the one standard error rule selection. OneSE is just an option for them. It's not very necessary to change the naming.

@lbluque
Copy link
Collaborator Author

lbluque commented Jan 11, 2023

I prefer not to rename these classes because these classes are not only implemented to use the one standard error rule selection. OneSE is just an option for them. It's not very necessary to change the naming.

Ah ok that makes sense. Then I think we should find a name that is descriptive to the class (perhaps it should have "CV" in there bc that's what it's basing the optimization, right?), or perhaps just name it the same as sklearn GridSearchCV, but then I think it's confusing what the difference between the one here is.

Any suggestion?

@lbluque lbluque changed the title Rename to model_selection and OneSEGridSearchCV Rename to model_selection, GridSearchCV and LineSearchCV Jan 11, 2023
@lbluque lbluque requested a review from qchempku2017 January 11, 2023 03:45
@lbluque
Copy link
Collaborator Author

lbluque commented Jan 11, 2023

renamed to GridSearchCV and LineSearchCV

@lbluque lbluque merged commit eef935f into CederGroupHub:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants