Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHARE-526 Incorrect google translations broke the screen #4328

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

makre10
Copy link
Contributor

@makre10 makre10 commented Sep 18, 2023


Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name and id of the Jira ticket in the PR’s title eg.: SHARE-666 The devils ticket
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no warnings and errors
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Verify that all tests are passing (CI), if not please state the test cases in the section below
  • Perform a self-review of the changes
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • Put your ticket into the Code Review section in Jira
  • Post a message in the #catroweb Slack channel and ask for a code reviewer
  • Check that your pull request has been successfully deployed to https://web-test-1.catrob.at/

Additional Description

TODO: Add additional information that is not in your commit-message here

Tests - additional information

TODO: add additional information about testruns here

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #4328 (5b5b774) into develop (19eb5f6) will decrease coverage by 1.34%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4328      +/-   ##
=============================================
- Coverage      49.43%   48.10%   -1.34%     
  Complexity      5688     5688              
=============================================
  Files            661      661              
  Lines          20483    20483              
=============================================
- Hits           10126     9853     -273     
- Misses         10357    10630     +273     
Flag Coverage Δ
behat 45.82% <ø> (-1.43%) ⬇️
phpunit 8.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dmetzner dmetzner merged commit 3468612 into Catrobat:develop Sep 19, 2023
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants