Skip to content

Commit

Permalink
Merge pull request #4336 from makre10/SHARE-433
Browse files Browse the repository at this point in the history
SHARE-433 Add Studios to sidebar
  • Loading branch information
dmetzner authored Sep 28, 2023
2 parents 4047d6d + ba24714 commit faee9e6
Show file tree
Hide file tree
Showing 78 changed files with 106 additions and 3 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ jobs:
with:
name: PhpUnitTestReport
path: tests/TestReports/CoverageReports/PhpUnit

- uses: codecov/codecov-action@v3
with:
# token: ${{ secrets.CODECOV_TOKEN }} # not required for public repos
Expand Down Expand Up @@ -235,7 +234,6 @@ jobs:
cat tests/TestReports/Behat/${{ matrix.testSuite }}.log;
docker exec app.catroweb bin/behat -s ${{ matrix.testSuite }} -f pretty;
fi
- uses: codecov/codecov-action@v3
with:
# token: ${{ secrets.CODECOV_TOKEN }} # not required for public repos
Expand Down
1 change: 1 addition & 0 deletions config/features.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@
'Test-Flag' => false,
'New-Feature' => false,
'Experimental-Feature' => true,
'Sidebar-Studio-Link-Feature' => false,
];
5 changes: 5 additions & 0 deletions src/Application/Controller/Test/TestFeatureFlagController.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,9 @@ public function testFlagAction(): Response
{
return $this->render('Admin/Tools/test_feature_flag.html.twig', ['enabled' => $this->manager->isEnabled('Test-Flag')]);
}

public function testFlagSidebarStudioLink(): Response
{
return $this->render('Admin/Tools/feature_flag_sidebar_studio_link.html.twig', ['enabled' => $this->manager->isEnabled('Sidebar-Studio-Link-Feature')]);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{% if enabled %}
<li class="nav-item" >
<a class="nav-link" href="{{ url('studios_overview') }} id="btn-studio"">
<span class="sidebar-link-icon material-icons">group_work</span>
<span class="sidebar-link-text">{{ 'menu.studio'|trans({}, "catroweb") }}</span>
</a>
</li>
{% endif %}
7 changes: 7 additions & 0 deletions templates/Default/sidebar.html.twig
Original file line number Diff line number Diff line change
Expand Up @@ -113,13 +113,20 @@

{# Always visible #}


<li class="nav-item">
<a class="nav-link" href="{{ url('media_library_overview') }}">
<span class="sidebar-link-icon material-icons">collections</span>
<span class="sidebar-link-text">{{ 'menu.mediaLibrary'|trans({}, "catroweb") }}</span>
</a>
</li>

{{ render(controller(
'App\\Application\\Controller\\Test\\TestFeatureFlagController::testFlagSidebarStudioLink'
)) }}



<li class="nav-item">
<a class="nav-link" href="{{url('help')}}" id="btn-tutorials">
<span class="sidebar-link-icon material-icons">help_outline</span>
Expand Down
14 changes: 13 additions & 1 deletion tests/BehatFeatures/web/admin/feature_flag.feature
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,16 @@ Scenario: Overriding test feature with header true:
Scenario: Overriding test feature with header false:
Given I am on the page "/app/featureflag/test" with header "X-Feature-Flag-Test-Flag" equal to "0"
And I wait for the page to be loaded
Then I should see "Test feature is disabled!"
Then I should see "Test feature is disabled!"

Scenario: List Studio Link Feature Flags:
Given I log in as "Admin" with the password "123456"
And I am on "/admin/featureflag/list"
Then I should see "Sidebar-Studio-Link-Feature"







1 change: 1 addition & 0 deletions translations/catroweb.af_ZA.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios
login:
login: Login
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.ar_SA.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ menu:
helpAndTutorials: تعليمات ودروس
followersAndFollowing: متابع
mediaLibrary: مكتبة الوسائط
studio: استوديوهات
login:
login: تسجيل الدخول
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.az_AZ.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ menu:
helpAndTutorials: Kömək və təlimatlar
followersAndFollowing: İzləyici
mediaLibrary: Media library
studio: Studiyalar
login:
login: Giriş
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.bg_BG.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios
login:
login: Login
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.bn_BD.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,7 @@ menu:
helpAndTutorials: সহায়তা ও টিউটোরিয়াল
followersAndFollowing: অনুসরণকারী
mediaLibrary: মিডিয়া লাইব্রেরি
studio: স্টুডিও
login:
login: প্রবেশ করুন
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.bs_BA.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Pomoć i tutorijali
followersAndFollowing: Follower
mediaLibrary: Biblioteka medija
studio: Studios
login:
login: Prijava
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.ca_ES.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios
login:
login: Login
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.chr_US.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios
login:
login: Login
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.cs_CZ.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Knihovna médií
studio: Studia
login:
login: Přihlásit se
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.da_DK.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios
login:
login: Log på
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.de_DE.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,7 @@ menu:
helpAndTutorials: Hilfe & Tutorials
followersAndFollowing: Abonnenten
mediaLibrary: Medienbibliothek
studio: Studios
login:
login: Einloggen
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.el_GR.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Βιβλιοθήκη πολυμέσων
studio: Στούντιο
login:
login: Σύνδεση
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.en.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios

login:
login: Login
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.en_AU.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios
login:
login: Login
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.en_CA.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios
login:
login: Login
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.en_GB.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios
login:
login: Login
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.es_ES.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ menu:
helpAndTutorials: Ayuda y tutoriales
followersAndFollowing: Seguidor
mediaLibrary: Libreria de medios
studio: Estudios
login:
login: Login
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.eu_ES.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios
login:
login: Login
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.fa_AF.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ menu:
helpAndTutorials: کمک و آموزش
followersAndFollowing: دنبال کننده
mediaLibrary: کتابخانه ی رسانه
studio: استودیوها
login:
login: وارد شدن
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.fa_IR.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,7 @@ menu:
helpAndTutorials: کمک و آموزش
followersAndFollowing: پی‌گیر
mediaLibrary: کتابخانه ی رسانه
studio: استودیوها
login:
login: ورود به سیستم
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.fi_FI.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios
login:
login: Login
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.fr_FR.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ menu:
helpAndTutorials: Aide et tutoriels
followersAndFollowing: Suiveurs
mediaLibrary: Bibliothèque multimédia
studio: Ateliers
login:
login: Se connecter
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.gl_ES.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios
login:
login: Iniciar sesión
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.gu_IN.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: સ્ટુડિયો
login:
login: લોગીન
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.ha_HG.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios
login:
login: Login
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.he_IL.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios
login:
login: התחברות
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.hi_IN.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ menu:
helpAndTutorials: सहायता और ट्यूटोरियल
followersAndFollowing: अनुगामी
mediaLibrary: मीडिया लाइब्रेरी
studio: स्टूडियो
login:
login: प्रवेश करे
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.hr_HR.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,7 @@ menu:
helpAndTutorials: Pomoc i Tutorijali
followersAndFollowing: Sljedbenik
mediaLibrary: Biblioteka medijskih sadržaja
studio: Studiji
login:
login: prijava
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.hu_HU.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios
login:
login: Bejelentkezés
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.id_ID.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ menu:
helpAndTutorials: Bantuan & tutorial
followersAndFollowing: Pengikut
mediaLibrary: Perpustakaan media
studio: Studio
login:
login: Gabung
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.ig_NG.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios
login:
login: Login
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.it_IT.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,7 @@ menu:
helpAndTutorials: Tutorial e aiuto
followersAndFollowing: Seguace
mediaLibrary: Libreria multimediale
studio: Studi
login:
login: Login
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.ja_JP.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ menu:
helpAndTutorials: ヘルプとチュートリアル
followersAndFollowing: フォロワー
mediaLibrary: メディア ライブラリー
studio: スタジオ
login:
login: ログイン
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.ka_GE.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios
login:
login: Login
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.kab_KAB.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios
login:
login: Login
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.kk_KZ.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Анықтама және туториалдар
followersAndFollowing: Бақылау
mediaLibrary: Медиатека
studio: Студия
login:
login: Кіру
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.kn_IN.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios
login:
login: Login
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.ko_KR.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,7 @@ menu:
helpAndTutorials: 도움말 & 튜터리얼
followersAndFollowing: 팔로워
mediaLibrary: 미디어 라이브러리
studio: 스튜디오
login:
login: 로그인
button:
Expand Down
1 change: 1 addition & 0 deletions translations/catroweb.lt_LT.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ menu:
helpAndTutorials: Help & tutorials
followersAndFollowing: Follower
mediaLibrary: Media library
studio: Studios
login:
login: Login
button:
Expand Down
Loading

0 comments on commit faee9e6

Please sign in to comment.