-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fake languages to pretty-print code & types #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-botbol
force-pushed
the
vbot@prettier_types
branch
from
October 30, 2024 18:32
d32b6aa
to
8bf3491
Compare
vincent-botbol
changed the title
[WIP] Add fake languages to pretty-print types
Add fake languages to pretty-print code & types
Oct 30, 2024
vincent-botbol
changed the title
Add fake languages to pretty-print code & types
[WIP] Add fake languages to pretty-print code & types
Oct 30, 2024
vincent-botbol
changed the title
[WIP] Add fake languages to pretty-print code & types
Add fake languages to pretty-print code & types
Oct 31, 2024
rprimet
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
denismerigoux
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #51, do not merge before it lands.
This PR adds fake textmate grammars in order to properly display to the users type of expression on mouse hovering.
WIP: I would also like to add the full display of data structures when hovering on type expressions.Status update: this PR misses a small surface printer to display enumeration & structures on hoveringHere are some examples of what it looks like: