Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usig ESLint during lint-stage and workflow #758

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

CatChen
Copy link
Owner

@CatChen CatChen commented Nov 26, 2024

No description provided.

Copy link

what-the-diff bot commented Nov 26, 2024

PR Summary

  • Enhanced GitHub workflow
    This update adds eslint-suggestion-action@v4 to our workflow. This is a tool that helps maintain good coding standards in our source code. It is designed to fail checks under certain conditions, based on the event type.

  • Tweaked deno.json
    The adjustments in the formatting for lib, include, and exclude arrays are for better readability. This change will make it easier for all to understand what elements or files are being considered for certain actions.

  • Upgraded package.json

    • The configuration for JavaScript and TypeScript files has been updated to use eslint --fix in place of prettier -w. This change is aimed at improving code quality and consistency.
    • We have ensured continued support for JSON, and also now added js.flow files in the configuration. This expands the range of file types that our lint-staging process supports.

Copy link
Owner Author

CatChen commented Nov 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (f44da55) to head (38e381c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #758   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files           1        1           
  Lines          52       52           
  Branches       10       10           
=======================================
  Hits           51       51           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatChen CatChen self-assigned this Nov 26, 2024
@CatChen CatChen requested a review from Copilot November 26, 2024 05:33
@CatChen CatChen marked this pull request as ready for review November 26, 2024 05:33

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated no suggestions.

Files not reviewed (2)
  • deno.json: Language not supported
  • package.json: Language not supported
@CatChen CatChen force-pushed the 11-25-usig_eslint_during_lint-stage_and_workflow branch from 6410dbe to 38e381c Compare November 26, 2024 05:38
@CatChen CatChen merged commit 76f37e2 into main Nov 26, 2024
20 checks passed
@CatChen CatChen deleted the 11-25-usig_eslint_during_lint-stage_and_workflow branch November 26, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant