Clarify acceptable_conclusions
format
#248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @CasperWA and thanks for
push-protected
! 🙂We use this action as part of our workflow on @OpenTermsArchive and, when combining it with @OpenTermsArchive/changelog-action, we need to skip changelog checks on our
main
branches.As part of setting up
push-protected
, I spontaneously read “list of acceptable statuses” in theacceptable_conclusions
documentation as[ 'success', 'skipped' ]
. This changeset suggests a more explicit way to document the expected format. I had a quick look at changing the parsing itself, to support lists or at least trim the entries in the string, but I understand that you use Python’s nativein
to check values, and changing this would be a bigger intervention on the codebase.Cheers!
Matti