Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify acceptable_conclusions format #248

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

MattiSG
Copy link
Contributor

@MattiSG MattiSG commented Jul 11, 2024

Hi @CasperWA and thanks for push-protected! 🙂

We use this action as part of our workflow on @OpenTermsArchive and, when combining it with @OpenTermsArchive/changelog-action, we need to skip changelog checks on our main branches.

As part of setting up push-protected, I spontaneously read “list of acceptable statuses” in the acceptable_conclusions documentation as [ 'success', 'skipped' ]. This changeset suggests a more explicit way to document the expected format. I had a quick look at changing the parsing itself, to support lists or at least trim the entries in the string, but I understand that you use Python’s native in to check values, and changing this would be a bigger intervention on the codebase.

Cheers!
Matti

Copy link
Owner

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers, this is indeed more clear, especially when including the example 👍

@CasperWA
Copy link
Owner

I will merge as is. The tests here will currently not run as intended due to limited access to GitHub secrets from external contributors, but the change should and will never have an effect on any of the current CI tests.

@CasperWA CasperWA merged commit 4b4daac into CasperWA:main Jul 11, 2024
10 of 11 checks passed
@MattiSG MattiSG deleted the patch-1 branch July 11, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants