Check attributions text before loading them #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #89763: [teqstream] Duplicate CARTO logo in attribution. |
moicalcob
changed the title
VictorVelarde
approved these changes
Dec 28, 2021
VictorVelarde
deleted the
feature/sc-89763/teqstream-duplicate-carto-logo-in-attribution
branch
|
v4.2.2-2 tag created |
|
@moicalcob, now you should be able to create a PR in cartodb to use this tag in prod. Change would be something like:
Remember also to bump assets in package.json |
|
That's nice! Thanks so much!! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources
Shortcut story
Context
Datasets' attributions are not working fine when loading a map. Sometimes the attributions are duplicated, or an empty space is being shown.
Changes
I've checked that the attributions array doesn't contain duplicated elements. I've also checked with a regular expression that the string that is going to be rendered is clean.