Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix choropleth legends margin #2157

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Fix choropleth legends margin #2157

merged 1 commit into from
Jun 29, 2018

Conversation

Jesus89
Copy link
Member

@Jesus89 Jesus89 commented Jun 28, 2018

@@ -293,6 +293,10 @@ $maxLegendContainerHeight: 300px;
z-index: 3;
}

.CDB-Legend-item {
height: 100%

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declaration should be terminated by a semicolon

Copy link
Contributor

@rjimenezda rjimenezda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said on the other one, if it looks good then 👍

I would try to mix and match legend types as much as possible, and check all possible viewports, both in builder and in embed, particularly with widgets, which end up taking a lot of space

@Jesus89 Jesus89 merged commit 497789c into master Jun 29, 2018
@Jesus89 Jesus89 deleted the fix-legend-margin branch June 29, 2018 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants