Transpile ES6 code through Babel in Webpack 4 #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesusbotella
changed the title
rubenmoya
approved these changes
Jun 28, 2018
| @@ -25,7 +25,8 @@ | |||
| "Ruben Moya <[email protected]>", | |||
| "Jesus Arroyo Torrens <[email protected]>", | |||
| "Iago Lastra <[email protected]>", | |||
| "Elena Torró <[email protected]>" | |||
| "Elena Torró <[email protected]>", | |||
| "Jesús Botella <[email protected]>" | |||
There was a problem hiding this comment.
Ssshh...nobody's gonna notice 😂
There was a problem hiding this comment.
Hey! What's going on here? 😂
rjimenezda
approved these changes
Jul 3, 2018
| "babel-preset-es2015": "~6.24.1", | ||
| "babelify": "~7.3.0", | ||
| "babelify": "^7.3.0", |
|
I think I did a bundle size comparison and there wasn't a big difference in terms of size :( What can be interesting is to reduce the final bundle, because it is now ~300kb minified. |
|
That's fine, we're adding support for ES6 so I was worried we might have some extra boilerplate. 300kb is huge though 🤔 |
|
Yes, I passed the Webpack Bundle Analyzer, and it was mostly jQuery, Backbone, and Underscore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables us to write ES6 code in Carto.js, by later transpiling it when making the production bundle.
And I did the update to Webpack 4 as well because I saw it easy 🤷♂️
This PR has to be merged in conjunction with CartoDB/cartodb#14117