Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] Change launchTask to Task.launch #76

Merged
merged 1 commit into from
Sep 24, 2016
Merged

[BREAKING] Change launchTask to Task.launch #76

merged 1 commit into from
Sep 24, 2016

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Sep 24, 2016 •
edited
Loading

Another option is launch(task: Task, standardInput: SignalProducer<Data, NoError>? = nil) related to Swift 3 API Design Guidelines.

Diff ignoring whitespace: https://github.com/Carthage/ReactiveTask/pull/76/files?w=1

mdiep
mdiep approved these changes Sep 24, 2016
View reviewed changes
Copy link
Member

@mdiep mdiep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense. 👍🏻

@mdiep mdiep merged commit 42d3218 into master Sep 24, 2016
@mdiep mdiep deleted the task-launch branch September 24, 2016 19:48
@ikesyo
Copy link
Member Author

ikesyo commented Sep 25, 2016

Thanks! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdiep mdiep mdiep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikesyo @mdiep