Quote whitespace-containing arguments in Task.description #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,6 +48,13 @@ public struct Task { | |||
|
|
|||
| extension Task: CustomStringConvertible { | |||
| public var description: String { | |||
| let arguments = self.arguments.map { argument -> String in | |||
There was a problem hiding this comment.
Maybe extract this into a escape function in a String extension?
|
Updated ✨ How does it look like now? |
ikesyo
changed the title
| private extension CollectionType where Generator.Element == String { | ||
| func escaped() -> [String] { | ||
| let whitespaceCharacterSet = NSCharacterSet.whitespaceCharacterSet() | ||
| return map { string -> String in |
There was a problem hiding this comment.
The return type here is redundant.
This reverts commit 3ead6f5.
| @@ -46,9 +46,20 @@ public struct Task { | |||
| } | |||
| } | |||
|
|
|||
| private extension String { | |||
| var escaped: String { | |||
| let whitespaceCharacterSet = NSCharacterSet.whitespaceCharacterSet() | |||
There was a problem hiding this comment.
Calling this for each call would be okay?
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Carthage/Carthage#1318.