Simplify some naming #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| private func ==<Key : Equatable, Value : Equatable>(lhs: [Key : Value]?, rhs: [Key : Value]?) -> Bool { |
There was a problem hiding this comment.
This should be styled as follows:
<Key: Equatable, Value: Equatable>(lhs: [Key: Value]?, rhs: [Key: Value]?)
|
I've experimented with the changes in Carthage, and I had no problem to put them in! Looks good to me and just a few stylistic notes. 👍 |
|
👾 |
| /// Launches a new shell task, using the parameters from `taskDescription`. | ||
| /// Launches a new shell task. | ||
| /// | ||
| /// - Parameters: |
There was a problem hiding this comment.
I just discovered this yesterday in the apple/swift documentation. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really dislike some of the current naming in ReactiveTask. This PR cleans that up and makes a few more breaking changes while I'm at it:
TaskDescriptiontoTasklaunchPath:parameter name fromTask.initReactiveTaskErrortoTaskErrorstandardInputfromTasktolaunchTaskTaskconform toHashableLaunchcase toTaskEventthat sends theTaskThe latter 3 changes were motivated by a desire to print executed commands in Carthage. Right now, we only print the output of commands. It'd be nice to print the commands themselves.