Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed ReactiveCocoa branch name #32

Merged
merged 4 commits into from
Jul 23, 2015
Merged

Changed ReactiveCocoa branch name #32

merged 4 commits into from
Jul 23, 2015

Conversation

AndrewSB
Copy link
Contributor

ReactiveCocoa no longer has the swift-development branch
Moving to the swift-1.2 branch

ReactiveCocoa no longer has the swift-development branch
Moving to the swift-1.2 branch
@ikesyo
Copy link
Member

ikesyo commented Jul 22, 2015

Thank you for the pull request! However, that swift-1.2 branch is outdated (I don't know why the branch still exists). So we should use the latest v3.0-RC.1 release tag instead.

@AndrewSB
Copy link
Contributor Author

thanks @ikesyo made the change!

@@ -1 +1 @@
github "ReactiveCocoa/ReactiveCocoa" "swift-development"
github "ReactiveCocoa/ReactiveCocoa" "6c37b5ef416799a3a2a61ff78f051d5deb0d76b2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please use v3.0-RC.1 tag, not the commit SHA?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, Cartfile.resolved and the submodule reference should be updated too. You could use $ carthage update --use-submodules --no-build --no-use-binaries.

@ikesyo ikesyo self-assigned this Jul 22, 2015
@AndrewSB
Copy link
Contributor Author

Sorry about that @ikesyo! Didn't realize git rev-parse could reference tags

@ikesyo
Copy link
Member

ikesyo commented Jul 23, 2015

Looks good! 👍 Thanks for your work. 💖

ikesyo added a commit that referenced this pull request Jul 23, 2015
Changed ReactiveCocoa branch name
@ikesyo ikesyo merged commit 9892ed7 into Carthage:master Jul 23, 2015
@AndrewSB AndrewSB deleted the patch-1 branch July 23, 2015 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants