Update ReactiveSwift to 5.0 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 17, 2019
Package.swift
Outdated
| .package(url: "https://github.com/antitypical/Result.git", from: "4.1.0"), | ||
| .package(url: "https://github.com/ReactiveCocoa/ReactiveSwift.git", from: "5.0.0"), | ||
| .package(url: "https://github.com/Quick/Quick.git", from: "2.0.0"), | ||
| .package(url: "https://github.com/Quick/Nimble.git", from: "8.0.1"), |
There was a problem hiding this comment.
Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)
mdiep
requested changes
Mar 20, 2019
| @@ -389,7 +389,7 @@ | |||
| CLANG_WARN_SUSPICIOUS_MOVE = YES; | |||
| CURRENT_PROJECT_VERSION = 1; | |||
| GCC_NO_COMMON_BLOCKS = YES; | |||
| MACOSX_DEPLOYMENT_TARGET = 10.9; | |||
| MACOSX_DEPLOYMENT_TARGET = 10.10; | |||
There was a problem hiding this comment.
Instead of changing the deployment target for the project/framework, can you change it just for the test target?
|
Thanks for taking this on! |
|
No worries at all, I'm happy to help! I think I've addressed all of the PR comments. I'm not sure why |
mdiep
approved these changes
Mar 21, 2019
|
Weird. I think we need to figure that out. Any ideas, @ikesyo? |
|
CocoaPods's version is the problem so updated in 291a87a. |
ikesyo
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.