feat: added new alias message type

CaritasDeutschland · Jun 7, 2021 · f3d07cb · f3d07cb
1 parent 4b1db38
commit f3d07cb
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 4 deletions.
diff --git a/api/messageservice.yaml b/api/messageservice.yaml
@@ -314,7 +314,7 @@ paths:
       tags:
         - message-controller
       summary: 'Saves a new empty system message containing the provided message type in the alias.
-      [Authorization: Role: user, consultant]'
+      [Authorization: Role: user, consultant, technical]'
       operationId: saveAliasOnlyMessage
       parameters:
         - name: rcGroupId
@@ -478,9 +478,10 @@ components:
     MessageType:
       type: string
       enum:
+        - "FINISHED_CONVERSATION"
+        - "FORWARD"
         - "FURTHER_STEPS"
         - "UPDATE_SESSION_DATA"
-        - "FORWARD"
         - "VIDEOCALL"
 
     UserDTO:

diff --git a/src/main/java/de/caritas/cob/messageservice/config/SecurityConfig.java b/src/main/java/de/caritas/cob/messageservice/config/SecurityConfig.java
@@ -75,9 +75,9 @@ protected void configure(HttpSecurity http) throws Exception {
         .antMatchers("/messages/new")
         .hasAnyAuthority(USER_DEFAULT, CONSULTANT_DEFAULT, TECHNICAL_DEFAULT, ANONYMOUS_DEFAULT)
         .antMatchers("/messages/forward", "/messages/feedback/new")
-        .hasAnyAuthority(USE_FEEDBACK)
+        .hasAuthority(USE_FEEDBACK)
         .antMatchers("/messages/aliasonly/new")
-        .hasAuthority(USER_DEFAULT)
+        .hasAnyAuthority(USER_DEFAULT, TECHNICAL_DEFAULT)
         .anyRequest()
         .denyAll();
   }

diff --git a/...va/de/caritas/cob/messageservice/api/controller/MessageControllerAuthorizationTestIT.java b/...va/de/caritas/cob/messageservice/api/controller/MessageControllerAuthorizationTestIT.java
@@ -473,4 +473,24 @@ public void getMessagesStream_Should_ReturnNoContent_When_AnonyousAuthority()
         .andExpect(status().isNoContent());
   }
 
+  @Test
+  @WithMockUser(authorities = {AuthorityValue.TECHNICAL_DEFAULT})
+  public void saveAliasOnlyMessage_Should_ReturnCreatedAndCallPostGroupMessageFacade_When_TechnicalDefaultAuthority()
+      throws Exception {
+    AliasOnlyMessageDTO aliasOnlyMessageDTO =
+        new EasyRandom().nextObject(AliasOnlyMessageDTO.class);
+
+    mvc.perform(
+        post(PATH_POST_CREATE_ALIAS_ONLY_MESSAGE)
+            .cookie(csrfCookie)
+            .header(CSRF_HEADER, CSRF_VALUE)
+            .header("rcGroupId", RC_GROUP_ID)
+            .contentType(MediaType.APPLICATION_JSON)
+            .content(new ObjectMapper().writeValueAsString(aliasOnlyMessageDTO))
+            .accept(MediaType.APPLICATION_JSON))
+        .andExpect(status().isCreated());
+
+    verify(postGroupMessageFacade, times(1)).postAliasOnlyMessage(any(), any());
+  }
+
 }