Upgrade to hydra-0.16 #166
Conversation
locallycompact
force-pushed
the
lc/hydra-0.16
branch
3 times, most recently
from
1462fd2 to
905a65b
Compare
Hydra 0.16 drops JSON encoding of transactions in favour of a CBOR representation only. This updates the hydra submodule to provide a golden test file in the new format. Co-Authored by Daniel Firth <[email protected]>
locallycompact
force-pushed
the
lc/hydra-0.16
branch
from
47d8ab1 to
da05d0b
Compare
There was a problem hiding this comment.
Besides the code changes requested, it seems like this is not working in the end-to-end test.
In fact, Hydra end-to-end tests seem to be broken for longer already? I tried kupo 2.8 and 2.7 against latest released hydra 0.15.0 and both did not work either. CC @KtorZ
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| #### Added | |||
|
|
|||
| * Compatibility with hydra-node 0.16.0. | |||
There was a problem hiding this comment.
Should: add this to a new, unreleased section as 2.8.0 seems to have already been released.
This is to be discussed! Having the currentNetworkTip be executed on test case creation does prevent running the test suite without a CARDANO_NODE_SOCKET environment variable. For only running hydra tests, we move these back into tests which later refer to the 'tip' variable. These tests might become slower now.
|
We can use cardano-scaling/hydra#1378 now to have a constant stream of snapshots (= blocks) and the end-to-end test "can connect" should pass now against this (while |
This will enforce correct operation of transaction / snapshot decoding for Hydra (and block decoding for the other providers).
|
Well.. as this got merged, we should release hydra |
|
Note: I haven't tested the Hydra integration myself. I will in the upcoming days for the next Kupo release. |
Hydra 0.16 drops JSON encoding of transactions in favour of a CBOR representation only. This updates the hydra submodule to provide a golden test file in the new format.
Co-Authored by Daniel Firth [email protected]