Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Globalhashes crash if the date isn't in the stock cache #73

Closed
CaptainSpam opened this issue Feb 28, 2020 · 1 comment
Closed

Globalhashes crash if the date isn't in the stock cache #73

CaptainSpam opened this issue Feb 28, 2020 · 1 comment
Assignees
@CaptainSpam
Labels
bug Component-StockFetcher Priority-High

Comments

@CaptainSpam
Copy link
Owner

There's reports of crashes when requesting Globalhashes. Tracing it down, it looks like it happens if the stock price hasn't been fetched yet, and more to the point, a logging statement is trying to dereference a null Graticule object. This should be a simple fix.
@CaptainSpam CaptainSpam self-assigned this Feb 28, 2020
CaptainSpam added a commit that referenced this issue Feb 28, 2020
@CaptainSpam
Added a Graticule null check in runStock().
03bb355 
Turns out that one debug line was always expecting mGrat to be non-null,
which it won't be if this is a Globalhash.  Now it's a bit more robust.

(this fixes issue #73)
@CaptainSpam
Copy link
Owner Author

There we go. Version 0.9.4.1 should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CaptainSpam CaptainSpam

Labels
bug Component-StockFetcher Priority-High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CaptainSpam