feat: Upload captions #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Betree
force-pushed
the
feat/upload-captions
branch
2 times, most recently
from
b52eb68 to
4f6eb5d
Compare
Betree
force-pushed
the
feat/upload-captions
branch
2 times, most recently
from
f0748b8 to
c9531b6
Compare
- Trying to fetch directly from the API is too dangerous at this point, since the API is blocked
- I've chosen to iterate on a GraphQL subtitles upload API
- Trying the GraphQL mutation with Absinthe, I got a "No query document supplied" error
-
```gql
mutation SetVideoCaptions($captions: Upload!) {
setVideoCaptions(videoId: 1, captions: $captions) {
captions {
text
}
}
}
```
- Decided to upgrade Absinthe to see how that goes
- [absinthe_ecto](https://github.com/absinthe-graphql/absinthe_ecto) is deprecated, so I'm looking to move to [dataloader](https://github.com/absinthe-graphql/dataloader)
- Updated the dependencies, now looking to migrate the actual `assoc` calls
Betree
force-pushed
the
feat/upload-captions
branch
from
c9531b6 to
53c9d81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.