Reduced number of exported chunks per region when no ceiling dimension is present. #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…32 by 32 instead of 34 by 34. Reducing the number of chunks generated by ~11.4% in theory (but probably less due to edges not generating all chunks).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when going through firstPass, we always run through a 34 by 34 chunk area to export a region. The reason there are 2 extra per axis is because padding was being used for the ceiling dimension since chunks rely on adjacent chunks. When not using the ceiling dimension, this adds some extra overhead to exports and this can theoretically be reduced by ~11.4%.
This change will only use a 34 by 34 area when a ceiling dimension is used. Otherwise, a 32 by 32 area will be used. This is particularly useful for larger exports where we don't cut off the edges of regions because of the map size.