Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: is_good_plan action split #987

Merged
merged 3 commits into from
Feb 3, 2025
Merged

feat: is_good_plan action split #987

merged 3 commits into from
Feb 3, 2025

Conversation

WcaleNieWolny
Copy link
Contributor

@WcaleNieWolny WcaleNieWolny commented Jan 26, 2025 •
edited
Loading

feat: split plan action checks by usage type (MAU/storage/bandwidth)

  • Add new columns to stripe_info table for tracking exceeded limits:
    • mau_exceeded
    • storage_exceeded
    • bandwidth_exceeded
  • Create new SQL functions for checking/setting exceeded status per type
  • Add action_type enum ('mau', 'storage', 'bandwidth')
  • Refactor is_allowed_action to check specific action types
  • Update update.ts to check MAU and bandwidth limits together
  • Add comprehensive tests for each limit type scenario

Part 1 of #941
CLI: Cap-go/CLI#377

@WcaleNieWolny WcaleNieWolny mentioned this pull request Jan 26, 2025
Open
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
14.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@riderx riderx merged commit 4ed97ee into main Feb 3, 2025
7 of 9 checks passed
@riderx riderx deleted the is_good_plan_action_split branch February 3, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WcaleNieWolny @riderx