Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch the consistency of transaction receipts with a different chain-id #143

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

jasonsong0
Copy link

@jasonsong0 jasonsong0 commented Sep 4, 2024

Description

There was a specific block height that used the Evmos default chain ID (9000).
This occurred from v8 to v8.1.1 (block heights from 10848200 to 10849447).

Due to this issue, third-party services encountered an 'invalid chain-id' error when attempting to verify transaction results.
This patch addresses the problem by ensuring that the transaction receipt returns the same results as before.

Check this PR for details

ps.
There was an issue with the PR process, so the commits already included in v8.1.2 were also included.
You can ignore the first three commits(904f07a, d1b7b45, 84537d7)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@jasonsong0 jasonsong0 marked this pull request as ready for review September 4, 2024 04:40
@dudong2 dudong2 requested a review from tkkwon1998 September 4, 2024 04:44
Copy link
Collaborator

@dudong2 dudong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit b13abca into Canto-Network:v8/develop Sep 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants