Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change default chain-id to canto_7700-1 #136

Merged

Conversation

dudong2
Copy link
Collaborator

@dudong2 dudong2 commented Aug 14, 2024

Description

There was a bug where upgrading from v7 to v8 would set ethermint_9000-1 as the default value if chain-id was not explicitly flagged. I fixed this to change it to canto_7700-1.

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dudong2 dudong2 self-assigned this Aug 14, 2024
@dudong2 dudong2 requested a review from dongsam August 14, 2024 15:02
@dudong2 dudong2 force-pushed the v8/change-default-chain-id branch from 1f13c51 to 27fc817 Compare August 14, 2024 15:14
@dongsam dongsam requested a review from tkkwon1998 August 14, 2024 15:50
@dudong2 dudong2 merged commit 9d3b516 into Canto-Network:v8/develop Aug 14, 2024
8 checks passed
@dudong2 dudong2 deleted the v8/change-default-chain-id branch August 14, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants