feat: remove recovery module #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkkwon1998
commented
Jul 28, 2023
| // Set the ICS4 wrappers for claims and recovery middlewares | ||
| app.RecoveryKeeper.SetICS4Wrapper(app.IBCKeeper.ChannelKeeper) | ||
| // Set the ICS4 wrappers for onboarding middleware | ||
| // SET ONBOARDING MIDDLEWARE ICS4 WRAPPER |
There was a problem hiding this comment.
Should set onboarding keeper ICS4Wrapper here
tkkwon1998
commented
Jul 28, 2023
| @@ -542,7 +504,7 @@ func NewCanto( | |||
| var transferStack porttypes.IBCModule | |||
|
|
|||
| transferStack = transfer.NewIBCModule(app.TransferKeeper) | |||
| transferStack = recovery.NewIBCMiddleware(*app.RecoveryKeeper, transferStack) | |||
| // ADD ONBOARDING MIDDLEWARE TO TRANSFER STACK | |||
There was a problem hiding this comment.
Add onboarding to transfer stack
tkkwon1998
commented
Jul 28, 2023
| app.TransferKeeper = ibctransferkeeper.NewKeeper( | ||
| appCodec, keys[ibctransfertypes.StoreKey], app.GetSubspace(ibctransfertypes.ModuleName), app.RecoveryKeeper, | ||
| appCodec, keys[ibctransfertypes.StoreKey], app.GetSubspace(ibctransfertypes.ModuleName), app.IBCKeeper.ChannelKeeper, |
There was a problem hiding this comment.
Must add app.OnboardingKeeper instead of placeholder app.IBCKeeper.ChannelKeeper
There was a problem hiding this comment.
I'll add this to onboarding module PR
|
@poorphd can you review this PR? |
|
Everything LGTM. I will update onboarding PR once this gets merged. |
poorphd
approved these changes
Jul 30, 2023
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the x/recovery module from canto. This module is no longer used after issues regarding different key types were solved.
App.go is prepped for easy merging of x/onboarding (#103).
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...