Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse reaction (super-elastic) electron collision reaction #1854

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

BangShiuh
Copy link
Contributor

@BangShiuh BangShiuh commented Feb 27, 2025

Changes proposed in this pull request

The reverse reaction rate of electron collision reaction is added. The reverse rate is calculated super-elastic formula. In the test, a reversible elastic reaction is used for testing purpose only. The reverse rate is the same as the forward rate if the threshold energy is zero.

  • Use commits from @speth for modification of the reverse rate.
  • Make electron collision plasma reaction (ECPR) reversible.
  • Add test for ECPR.
  • I will add the example later

If applicable, fill in the issue number this pull request is fixing

Cantera/enhancements#192

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 85.48387% with 9 lines in your changes missing coverage. Please review.

Project coverage is 74.41%. Comparing base (d095f70) to head (46856db).

Files with missing lines Patch % Lines
src/kinetics/ElectronCollisionPlasmaRate.cpp 79.16% 2 Missing and 3 partials ⚠️
src/kinetics/BulkKinetics.cpp 89.47% 0 Missing and 2 partials ⚠️
src/kinetics/InterfaceKinetics.cpp 84.61% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1854   +/-   ##
=======================================
  Coverage   74.40%   74.41%           
=======================================
  Files         386      386           
  Lines       53630    53651   +21     
  Branches     9065     9071    +6     
=======================================
+ Hits        39905    39925   +20     
+ Misses      10653    10652    -1     
- Partials     3072     3074    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants