-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autogenerated clib core objects #1842
Conversation
2c9199d
to
de65446
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1842 +/- ##
==========================================
- Coverage 74.43% 74.42% -0.01%
==========================================
Files 382 382
Lines 53492 53498 +6
Branches 9055 9056 +1
==========================================
+ Hits 39816 39817 +1
- Misses 10609 10613 +4
- Partials 3067 3068 +1 ☔ View full report in Codecov by Sentry. |
30bb2b7
to
b51277c
Compare
b51277c
to
ef63709
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small Python-related comments 😄
c4b84d3
to
50de8dc
Compare
Thanks @bryanwweber! All taken care of. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks good to me. Just a couple of suggestions.
50de8dc
to
cca4a12
Compare
@speth ... thanks for your comments, which are now addressed (I also rebased). |
Changes proposed in this pull request
Solution
,ThermoPhase
,Kinetics
,Transport
andMultiPhase
have reached parity with traditional CLib_orchestrate.py
is simplifiedIf applicable, fill in the issue number this pull request is fixing
Addresses Cantera/enhancements#220
Checklist
scons build
&scons test
) and unit tests address code coverage