Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate StFlow::evalResidual #1619

Merged
merged 8 commits into from
Jun 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions doc/sphinx/reference/onedim/governing-equations.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ solution to reduce the three-dimensional governing equations to a single dimensi
## Axisymmetric Stagnation Flow

The governing equations for a steady axisymmetric stagnation flow follow those derived
in Section 7.2 of {cite:t}`kee2017` and are implemented by class {ct}`StFlow`.
in Section 7.2 of {cite:t}`kee2017` and are implemented by class {ct}`Flow1D`.

*Continuity*:

Expand Down Expand Up @@ -99,7 +99,7 @@ $$
where $D_{ki}$ is the multicomponent diffusion coefficient and $D_k^T$ is the Soret
diffusion coefficient. Inclusion of the Soret calculation must be explicitly enabled
when setting up the simulation, on top of specifying a multicomponent transport model,
for example by using the {ct}`StFlow::enableSoret` method (C++) or setting the
for example by using the {ct}`Flow1D::enableSoret` method (C++) or setting the
{py:attr}`~cantera.FlameBase.soret_enabled` property (Python).

## Boundary Conditions
Expand Down Expand Up @@ -295,4 +295,4 @@ $$

$$
\dot{m}_\t{in,right} = - \rho(z_{\t{in,right}}) U_o(z_{\t{in,right}})
$$
$$
10 changes: 10 additions & 0 deletions include/cantera/clib/ctonedim.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,16 @@ extern "C" {

CANTERA_CAPI int inlet_setSpreadRate(int i, double v);

CANTERA_CAPI int flow1D_new(int iph, int ikin, int itr, int itype);
CANTERA_CAPI int flow1D_setTransport(int i, int itr);
CANTERA_CAPI int flow1D_enableSoret(int i, int iSoret);
CANTERA_CAPI int flow1D_setPressure(int i, double p);
CANTERA_CAPI double flow1D_pressure(int i);
CANTERA_CAPI int flow1D_setFixedTempProfile(int i, size_t n, const double* pos,
size_t m, const double* temp);
CANTERA_CAPI int flow1D_solveEnergyEqn(int i, int flag);

//! @todo: Remove all functions with `stflow` prefix after Cantera 3.1
CANTERA_CAPI int stflow_new(int iph, int ikin, int itr, int itype);
CANTERA_CAPI int stflow_setTransport(int i, int itr);
CANTERA_CAPI int stflow_enableSoret(int i, int iSoret);
Expand Down
10 changes: 5 additions & 5 deletions include/cantera/oneD/Boundary1D.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#include "Domain1D.h"
#include "cantera/thermo/SurfPhase.h"
#include "cantera/kinetics/InterfaceKinetics.h"
#include "StFlow.h"
#include "Flow1D.h"

namespace Cantera
{
Expand Down Expand Up @@ -109,8 +109,8 @@ class Boundary1D : public Domain1D
protected:
void _init(size_t n);

StFlow* m_flow_left = nullptr;
StFlow* m_flow_right = nullptr;
Flow1D* m_flow_left = nullptr;
Flow1D* m_flow_right = nullptr;
size_t m_ilr = 0;
size_t m_left_nv = 0;
size_t m_right_nv = 0;
Expand Down Expand Up @@ -176,7 +176,7 @@ class Inlet1D : public Boundary1D
size_t m_nsp = 0;
vector<double> m_yin;
string m_xstr;
StFlow* m_flow = nullptr;
Flow1D* m_flow = nullptr;
};

/**
Expand Down Expand Up @@ -293,7 +293,7 @@ class OutletRes1D : public Boundary1D
size_t m_nsp = 0;
vector<double> m_yres;
string m_xstr;
StFlow* m_flow = nullptr;
Flow1D* m_flow = nullptr;
};

/**
Expand Down
Loading
Loading