Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow ^↑ and ^↓ to work also during "search filtering" #32

Closed
paletochen opened this issue Jun 7, 2023 · 5 comments · Fixed by #34
Closed

Feature request: Allow ^↑ and ^↓ to work also during "search filtering" #32

paletochen opened this issue Jun 7, 2023 · 5 comments · Fixed by #34

Comments

@paletochen
Copy link

Let's say I have a huge list of secrets, to the point that ^↑ and ^↓ is not feasible.
I would still like to sort some secrets together.
It would be great if when i use the search feature to find relevant secrets through pattern search, that when i use ^↑ and ^↓ the entries are placed together.

Example: Interested secrets are in lines 1,2,3,4 and 1235

  • When i search i manage to filter just those lines
  • Go to the last entry (line 1235)
  • Press ^↑
  • Line 1235 will become Line 5
Canop added a commit that referenced this issue Jun 13, 2023
When a search filters entries, ctrl-up and ctrl-down
applies to filtered entries

Fix #32
@Canop
Copy link
Owner

Canop commented Jun 13, 2023

@paletochen Can you check the PR #34 ?

@paletochen
Copy link
Author

@Canop I just tried it and, it is not doing what I was expecting.

Let's say I have the following drawer:

1

I'd like to put all the red - XX entries together

I try a 1st search filtering like this
2

I then move red - 4 and bring it below red - 3
3

When i remove the filtering, this is how it looks like
4

If i try with a narrower filtering like this
5

and then move red - 4 again below red - 3
6

it looks like this
7

If i try another approach, like bringing red - 4 above red -3, to see if that does the trick
8

red -3 ends up being placed below all the entries that i had filtered out
9

I am not sure that behavior would be expected and therefore look like a good feature.

The problem i have in my real drawer is that all those other entries in between the ones i want to bring together are counted in the hundreds, so the result of the sorting doesn't really help. The desired entries end up being too far apart

@Canop
Copy link
Owner

Canop commented Jun 14, 2023

I don't see how moving is supposed to guess whether red-4 is supposed to go before or after pink-1 and pink-2. This doesn't really look like a move-when-filtering problem.
Isn't your real issue solved with #35 ?

@paletochen
Copy link
Author

I don't see how moving is supposed to guess whether red-4 is supposed to go before or after pink-1 and pink-2. This doesn't really look like a move-when-filtering problem. Isn't your real issue solved with #35 ?

I just tried #35 and I really like group matching. It gets closer to what i needed.

It would match exactly the expected behavior if i could also use #33 during a filtered search

I can imagine i would do, for the example mentioned above the following

Filter by red -
5

Select from the menu: Group matching

Within the same filtered search, select from the menu: Sort

Would then be possible to have Sort available during a filtered search?

@Canop
Copy link
Owner

Canop commented Jun 14, 2023

Would then be possible to have Sort available during a filtered search?

I'll see. But if I do it, I'll do it with the minimal amount of moves, so it wouldn't group items, just change the filtered subset order.

@Canop Canop closed this as completed in #34 Jun 14, 2023
Canop added a commit that referenced this issue Jun 14, 2023
When a search filters entries, ctrl-up and ctrl-down apply to filtered entries

Fix #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants