Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(trino): upgrade testcontainers to 4.7.2 #689

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

grieve54706
Copy link
Contributor

@grieve54706 grieve54706 commented Jul 23, 2024

Upgrade testcontainers and use the TrinoContainer of testcontainers instead of the container we made.

Relate testcontainers/testcontainers-python#642

Copy link
Contributor

@goldmedal goldmedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grieve54706 looks nice. Just one question.
BTW, I think you can link this PR to your PR in testcontainers repo. https://github.com/testcontainers/testcontainers-python/pull/642/files

Comment on lines +166 to +167
user=(info.user and info.user.get_secret_value()),
password=(info.password and info.password.get_secret_value()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curiously, why need to have an and operation here? For null checking? If yes, should we do the same thing for other properties?

Copy link
Contributor Author

@grieve54706 grieve54706 Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for None. Other information about the data source is not allowed to be none.

Verified

This commit was signed with the committer’s verified signature.
reneme René Meusel
upgrade testcontainers and use the TrinoContainer of testcontainers instead of the container we made
@grieve54706 grieve54706 force-pushed the feature/ibis/upgrade-testcontainers branch from 1d2f6d4 to aee1fca Compare July 24, 2024 03:02
@grieve54706 grieve54706 merged commit 971da4c into main Jul 24, 2024
3 of 4 checks passed
@grieve54706 grieve54706 deleted the feature/ibis/upgrade-testcontainers branch July 24, 2024 03:26
grieve54706 added a commit that referenced this pull request Dec 13, 2024
upgrade testcontainers and use the TrinoContainer of testcontainers instead of the container we made
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants