fix(use/http,use/http2,use/express,use/fastify): Check writable ins…

…tead of `closed` before writing to response Closes enisdenjo#69
CandisIO · Aug 23, 2023 · 3c71f69 · 3c71f69
1 parent f653d48
commit 3c71f69
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/use/express.ts b/src/use/express.ts
@@ -96,7 +96,7 @@ export function createHandler<Context extends OperationContext = undefined>(
     res.once('close', body.return);
     for await (const value of body) {
       const closed = await new Promise((resolve, reject) => {
-        if (res.closed) {
+        if (!res.writable) {
           // response's close event might be late
           resolve(true);
         } else {

diff --git a/src/use/fastify.ts b/src/use/fastify.ts
@@ -98,7 +98,7 @@ export function createHandler<Context extends OperationContext = undefined>(
     reply.raw.once('close', body.return);
     for await (const value of body) {
       const closed = await new Promise((resolve, reject) => {
-        if (reply.raw.closed) {
+        if (!reply.raw.writable) {
           // response's close event might be late
           resolve(true);
         } else {

diff --git a/src/use/http.ts b/src/use/http.ts
@@ -91,7 +91,7 @@ export function createHandler<Context extends OperationContext = undefined>(
     res.once('close', body.return);
     for await (const value of body) {
       const closed = await new Promise((resolve, reject) => {
-        if (res.closed) {
+        if (!res.writable) {
           // response's close event might be late
           resolve(true);
         } else {

diff --git a/src/use/http2.ts b/src/use/http2.ts
@@ -93,7 +93,7 @@ export function createHandler<Context extends OperationContext = undefined>(
     res.once('close', body.return);
     for await (const value of body) {
       const closed = await new Promise((resolve, reject) => {
-        if (res.closed) {
+        if (!res.writable) {
           // response's close event might be late
           resolve(true);
         } else {