Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move port definition from docker-compose.yml to override file #46

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

cicalese
Copy link
Contributor

In order to be able to disable caddy in environments that use other mechanisms for SSL termination, one needs to be able to prevent the ports from being exposed. Since it is not (yet) possible to remove properties that are defined in docker-compose.yml by overriding, optional properties must be specified in the override file instead.

@cicalese cicalese requested a review from jeffw16 July 25, 2023 03:51
Bump version to 1.3.1
@yaronkoren yaronkoren merged commit c01df3d into CanastaWiki:main Jul 27, 2023
@vedmaka
Copy link
Contributor

vedmaka commented Aug 25, 2023

While this workaround of not exposing ports works, it's not ideal since Caddy is still running and consuming resources. I'd suggest using Compose profiles instead to define which services to use

@cicalese
Copy link
Contributor Author

The work-around I use for that is to change the definition of caddy in the override file:

  caddy:
    image: alpine:latest
    restart: "no" 
    entrypoint: ["echo", "Caddy is disabled"]

It's a terrible hack, but it works for the time being until a better solution is proposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants